Skip to content

fix: remove orphaned duplicate ;; left over from Python 3.9 removal - #554

Merged
aavinash-nr merged 1 commit into
newrelic:masterfrom
aavinash-nr:fix/libbuild-orphaned-semicolon
Oct 12, 2026
Merged

aavinash-nr merged 1 commit into
newrelic:masterfrom
aavinash-nr:fix/libbuild-orphaned-semicolon

Conversation

@aavinash-nr

Copy link
Copy Markdown
Contributor

Summary

  • #552 removed the "python3.9") case arm from layer_name_str() in libBuild.sh but left its trailing ;; terminator behind, producing two consecutive ;; with no case pattern before the second one.
  • A bare ;; with no preceding pattern is invalid bash syntax, so libBuild.sh currently fails to parse at all on master — breaking every runtime's build (not just Python's), since every publish-layers.sh sources this file before doing anything runtime-specific.
  • Confirmed via bash -n libBuild.sh: this was the only remaining instance of the pattern in the file, and no other python3.9 references remain anywhere in libBuild.sh.

This is why the v14.7.0.2_nodejs tag's build failed with ../libBuild.sh: line 103: syntax error near unexpected token ;;'` — the same failure will hit the next release of any runtime until this merges.

Test plan

  • bash -n libBuild.sh passes cleanly after the fix (verified locally)
  • Confirmed no other python3.9 references remain in libBuild.sh
  • Re-run (or wait for) the next publish-*.yml tag push to confirm the Docker build's RUN ./publish-layers.sh build-* step no longer fails at the source ../libBuild.sh step

newrelic#552 removed the "python3.9") case arm from layer_name_str() in
libBuild.sh but left its trailing ;; terminator behind, producing two
consecutive ;; with no pattern before the second one. A bare ;; with
no preceding case pattern is invalid bash syntax, so libBuild.sh fails
to parse at all — breaking every runtime's build (not just Python's),
since every publish-layers.sh sources this file before doing anything
runtime-specific.

Confirmed via bash -n: this was the only remaining instance of the
pattern in the file, and no other python3.9 references remain
anywhere in libBuild.sh.

@Sashwatdas123 Sashwatdas123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aavinash-nr
aavinash-nr merged commit 0bac594 into newrelic:master Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants