Repository navigation
fix: Updated nodejs/publish-layers.sh to install the agent with the default install strategy of hoisted to reduce the size of the Node.js lambda layer - #555
Open
bizob2828 wants to merge 1 commit into
Conversation
… default install strategy of hoisted to reduce the size of the Node.js lambda layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this was introduced in #384. Which ironically was to create a slim build to avoid the opentelemetry deps for customers who have no intention of using the hybrid agent. By adding
--install-strategy=nestedthe dependency tree grew significantly for slim and non-slim layers. This is because thenestedstrategy does not dedupe dependencies of the same versions but instead replicates the same packages for every child that depends on it. See the doc for more information.What this meant is our agent is currently 98MB when installed was instead 195MB, causes some issues with customers who also had a lot of code in their lambda function. AWS imposes a limit of 250mb unzipped and since the agent itself is 195MB there isn't much room, see doc
Before fix:
After fix: