Repository navigation
Fix CodeQL findings in jira_secret_monitor.py - #82
Merged
Merged
Conversation
- Escape literal dots in the docs.google.com hostname regexes so they can't be satisfied by arbitrary characters (py/incomplete-hostname-regexp). - Redact JIRA_PASSWORD before logging the gottingen_hog command line (py/clear-text-logging-sensitive-data).
bmgbam
approved these changes
Aug 3, 2026
bmgbam
left a comment
bmgbam
left a comment
There was a problem hiding this comment.
lgtm. "linting failure is on every PR in the past 1.5 years. It's a broken/stale gate. A bit of tech debt that needs to be addressed separately."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs.google.comhostname regexes inscripts/jira_secret_monitor.pyso a crafted string likehttps://docsXgoogleXcom/d/FAKEIDcan no longer masquerade as a valid Google Docs link. Fixespy/incomplete-hostname-regexp.JIRA_PASSWORDbefore logging thegottingen_hogcommand line, which was previously logging the plaintext password at INFO level. Fixespy/clear-text-logging-sensitive-data.Addresses:
Test plan
python3 -m py_compile scripts/jira_secret_monitor.pypasses