feat(contacts): support pronouns property - #5639
Conversation
Closes nextcloud#5108 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@hamza221 This respects the RFC right? Because code looks good |
|
I think it respects the RFC, based on the changes to the I don't know how Nextcloud's Contacts app serializes the properties, but RFC9554 also mentions some optional parameters that don't seem to be mentioned anywhere in the commit:
|
Summary
PRONOUNSas a repeatable text contact property.Closes #5108
Test plan
npm run build