Skip to content

feat(contacts): support pronouns property - #5639

Open
xhon-pelushi wants to merge 1 commit into
nextcloud:mainfrom
xhon-pelushi:feat/pronouns-5108
Open

feat(contacts): support pronouns property#5639
xhon-pelushi wants to merge 1 commit into
nextcloud:mainfrom
xhon-pelushi:feat/pronouns-5108

Conversation

@xhon-pelushi

Copy link
Copy Markdown

Summary

  • Add RFC 9554 PRONOUNS as a repeatable text contact property.
  • Include it in lightweight CardDAV property fetches and cover serialization with Jest.

Closes #5108

Test plan

  • Jest: rfcProps + contact model tests
  • npm run build
  • UI: add/edit pronouns on a contact and verify round-trip save/reload

Closes nextcloud#5108

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@GVodyanov

Copy link
Copy Markdown
Contributor

@hamza221 This respects the RFC right? Because code looks good

@EnbyAce

EnbyAce commented Aug 27, 2026

Copy link
Copy Markdown

I think it respects the RFC, based on the changes to the tests/javascript/models/rfcProps.test.js file. The pronouns field should match PRONOUNS:they/them exactly, which does respect RFC 9554.

I don't know how Nextcloud's Contacts app serializes the properties, but RFC9554 also mentions some optional parameters that don't seem to be mentioned anywhere in the commit:

  • LANGUAGE
  • PREF
  • TYPE
  • ALTID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pronouns for contacts

4 participants