Skip to content

chore: removing unused properties about org chart #5646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madbob wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −16
Open

chore: removing unused properties about org chart #5646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/AppContent/ChartContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<script>
import { NcAppContent as AppContent } from '@nextcloud/vue'
import OrgChart from '../OrgChart.vue'
import logger from '../../services/logger.js'
import { getChart, transformNode } from '../../utils/chartUtils.js'

export default {
Expand Down
6 changes: 1 addition & 5 deletions src/components/AppContent/ContactsContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
</template>

<!-- main contacts details -->
<ContactDetails :contact-key="selectedContact" :contacts="sortedContacts" :reload-bus="reloadBus" />
<ContactDetails :contact-key="selectedContact" :reload-bus="reloadBus" />
</AppContent>
</template>

Expand Down Expand Up @@ -92,7 +92,7 @@
props: {
loading: {
type: Boolean,
default: true,

Check warning on line 95 in src/components/AppContent/ContactsContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Boolean prop should only be defaulted to false
},

contactsList: {
Expand All @@ -119,10 +119,6 @@
return this.$store.getters.getGroups
},

sortedContacts() {
return this.$store.getters.getSortedContacts
},

/**
* Is this a real group ?
* Aka not a dynamically generated one like `All contacts`
Expand Down Expand Up @@ -171,7 +167,7 @@
* Forward the newContact event to the parent
*/
newContact() {
this.$emit('new-contact')

Check warning on line 170 in src/components/AppContent/ContactsContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The "new-contact" event has been triggered but not declared on `emits` option
},

/**
Expand Down
6 changes: 0 additions & 6 deletions src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@
:property="property"
:contact="contact"
:local-contact="localContact"
:contacts="contacts"
:bus="bus"
:is-read-only="isReadOnly" />
</div>
Expand Down Expand Up @@ -496,11 +495,6 @@ export default defineComponent({
default: undefined,
},

contacts: {
type: Array,
default: () => [],
},

reloadBus: {
type: Object,
required: true,
Expand Down
5 changes: 0 additions & 5 deletions src/components/ContactDetails/ContactDetailsProperty.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@ export default {
default: null,
},

contacts: {
type: Array,
default: () => [],
},

bus: {
type: Object,
required: true,
Expand Down
Loading