Skip to content

doc: add DOMException section to errors API reference - #65206

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
zeexzeex:doc/domexception-errors-page
Sep 8, 2026
Merged

doc: add DOMException section to errors API reference#65206
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
zeexzeex:doc/domexception-errors-page

Conversation

@zeexzeex

@zeexzeex zeexzeex commented Aug 11, 2026

Copy link
Copy Markdown

Fixes #40789

Adds a ## Class: DOMException section to doc/api/errors.md, following the
AssertionError pattern of listing the class on the Errors page with a
cross-link to the existing Globals page entry.

Also documents:

  • Web IDL / MDN references for name and numeric code
  • That web-platform APIs may throw DOMException while some Node.js APIs
    throw a native AbortError with code 'ABORT_ERR'
  • That err?.name === 'AbortError' covers both cases

Builds on the previous closed attempt in #64236 and incorporates the
outstanding review suggestion from @aduh95.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core. labels Aug 11, 2026
@zeexzeex
zeexzeex force-pushed the doc/domexception-errors-page branch 2 times, most recently from c158dcc to f790e90 Compare August 11, 2026 08:15
@trivikr

trivikr commented Aug 24, 2026

Copy link
Copy Markdown
Member

@zeexzeex The merge commits don't work with node.js tooling. Can you please rebase?

Document DOMException on the Errors page (with a Globals cross-link)
and clarify AbortError vs DOMException for AbortSignal users.
Builds on nodejs#64236 review feedback. Fixes nodejs#40789.

Signed-off-by: Avocado <ujubongbong@gmail.com>
@zeexzeex
zeexzeex force-pushed the doc/domexception-errors-page branch from f790e90 to 3dd99a3 Compare August 24, 2026 01:48
@zeexzeex

Copy link
Copy Markdown
Author

Thanks for the review, @trivikr. Rebased.

@trivikr trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 7, 2026
@trivikr
trivikr requested a review from Renegade334 September 7, 2026 22:55
Comment thread doc/api/errors.md Outdated
@Renegade334

Copy link
Copy Markdown
Member

Missed a push?

@zeexzeex

zeexzeex commented Sep 8, 2026

Copy link
Copy Markdown
Author

Missed a push?

Pushed.

@zeexzeex
zeexzeex force-pushed the doc/domexception-errors-page branch from db2f7e4 to 16d6a42 Compare September 8, 2026 00:52
@Renegade334 Renegade334 added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Sep 8, 2026
Reference a single link definition for ABORT_ERR through an alias so
the code and the section heading do not carry separate definitions.

Signed-off-by: Avocado <ujubongbong@gmail.com>
@zeexzeex
zeexzeex force-pushed the doc/domexception-errors-page branch from 16d6a42 to f11a9a7 Compare September 8, 2026 01:03
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2026
@nodejs-github-bot
nodejs-github-bot merged commit e4186d6 into nodejs:main Sep 8, 2026
18 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e4186d6

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. errors Issues and PRs related to JavaScript errors originating in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: DOMException missing from “Errors” API reference docs page

5 participants