[v24.x] test: fix crypto tests against BoringSSL - #65808
Open
codebytere wants to merge 2 commits into
Open
Conversation
test-crypto-pqc-key-objects-ml-dsa and -ml-kem compare a seeded key's PKCS#8 export against the seed+expanded fixture on every backend. BoringSSL only writes the seed-only encoding, so expect the private_seed_only fixture there. main expects seed-only on every backend since nodejs#62178, which is semver-major, so the BoringSSL support backported in nodejs#63563 kept the old expectation. Refs: nodejs#63563 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
test-crypto-keygen-deprecation and test-crypto-keygen-duplicate-deprecated-option generate rsa-pss key pairs, which BoringSSL does not support. The other rsa-pss keygen tests skip there since nodejs#62883, but these two only exist on v24.x (nodejs#58706 removed them from main earlier), so its backport could not cover them. Refs: nodejs#62883 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
nodejs-github-bot
added
needs-ci
panva
approved these changes
Sep 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #65808 +/- ##
=================================================
+ Coverage 90.31% 90.32% +0.01%
=================================================
Files 711 714 +3
Lines 228425 231840 +3415
Branches 43160 43946 +786
=================================================
+ Hits 206293 209410 +3117
- Misses 14090 14158 +68
- Partials 8042 8272 +230 🚀 New features to boost your workflow:
|
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four
parallelcrypto tests fail on v24.x-staging when Node is built with--shared-opensslagainst BoringSSL (theboringsslthattools/nix/openssl-matrix.nixpins on main, 0.20260803.0). main is unaffected and its BoringSSL job is green; each of these is specific to how the BoringSSL work was backported to v24.x.test-crypto-pqc-key-objects-ml-dsaand-ml-kemcompare a seeded key's PKCS#8 export against the seed+expanded fixture, and BoringSSL only writes the seed-only encoding, so they now expectprivate_seed_onlythere. main expects seed-only on every backend since #62178 (semver-major), so the backport in #63563 kept the old expectation.test-crypto-keygen-deprecationandtest-crypto-keygen-duplicate-deprecated-optiongeneratersa-psskey pairs, which BoringSSL doesn't support; the other rsa-pss keygen tests skip since #62883, but these two were already gone from main (#58706), so that backport never touched them.Tests: built v24.x-staging against that BoringSSL on linux-x64 and ran
parallelandsequential; these four were the only BoringSSL-related failures and pass with this change. The OpenSSL paths are unchanged.cc @nodejs/crypto
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.