stream: improve handling of falsy errors in stream/iter - #65864
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Member
|
Lint error needs fixing /home/runner/work/node/node/lib/internal/streams/iter/push.js
Error: 57:7 error 'kNoFailReason' is assigned a value but never used no-unused-vars |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65864 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01%
==========================================
Files 771 771
Lines 264619 264779 +160
Branches 50231 50282 +51
==========================================
+ Hits 238653 238837 +184
+ Misses 16961 16921 -40
- Partials 9005 9021 +16
🚀 New features to boost your workflow:
|
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/stream-iter-fixes-3
branch
from
September 6, 2026 22:44
bd2e9b4 to
2794c65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.