build: do not use bundled simdutf when built with `--shared-simdutf` by aduh95 · Pull Request #65891 · nodejs/node

aduh95 · 2026-09-07T21:27:15Z

Now that v8/v8@a0607c5 has landed, we can mixing more than one simdutf instance. I'm also using this opportunity to clean up the $CONFIG_FLAGS generation is shell.nix, to not explicitly pass the lib and header paths to test our default values.

nodejs-github-bot · 2026-09-07T21:27:20Z

Review requested:

@nodejs/actions
@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

codecov · 2026-09-08T00:33:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (b3fb344) to head (f5856b5).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #65891   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files         771      771           
  Lines      265434   265434           
  Branches    50450    50452    +2     
=======================================
+ Hits       239332   239343   +11     
+ Misses      17045    17034   -11     
  Partials     9057     9057

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Original commit message: Rewrite simdutf include paths to allow getting it from system Change-Id: I2b7b4cb452c22ed72e0935662c3c7477954bc205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8319848 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#109702} Refs: v8/v8@a0607c5

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2026-09-09T09:38:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77238/

nodejs-github-bot · 2026-09-09T09:38:33Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7354/

nodejs-github-bot · 2026-09-09T09:38:58Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7354/

nodejs-github-bot · 2026-09-09T09:40:38Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7354/

github-actions · 2026-09-10T12:14:43Z

Platform	Number of requisites	Proportion of new derivations
`x86_64-linux`	501 -> 502 => +1	1 / 502 = 0.1%
`aarch64-linux`	502 -> 503 => +1	1 / 503 = 0.1%
`x86_64-darwin`	441 -> 442 => +1	1 / 442 = 0.2%
`aarch64-darwin`	444 -> 445 => +1	1 / 445 = 0.2%
Total	1888 -> 1892 => +4	4 / 1892 = 0.2%

Changelog

@@ -1707,0 +1708,2 @@
+/nix/store/qcx56k9ydsfqb0rf7aqvwr5bn2garm6k-simdutf-9.0.0 (aarch64-darwin)
+/nix/store/kcxcfg1qwkbz5v4g2xqsr2vya9dfikvx-simdutf-9.0.0 (aarch64-linux)
@@ -1708,0 +1711 @@
+/nix/store/hk944pibnxikndqzisn9yij3ldxbi8fx-simdutf-9.0.0 (x86_64-darwin)
@@ -1710,0 +1714 @@
+/nix/store/jr66csw2kp4975f2ih9605z0srqnx4vc-simdutf-9.0.0 (x86_64-linux)

nodejs-github-bot · 2026-09-10T20:41:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77318/

nodejs-github-bot · 2026-09-10T21:20:24Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7360/

nodejs-github-bot · 2026-09-11T09:54:39Z

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✖  This PR needs to wait 84 more hours to land (or 0 minutes if there is one more approval)
   ✖  GitHub CI failed with status: FAILURE

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

- Loading data for nodejs/node/pull/65891
✔  Done loading data for nodejs/node/pull/65891
----------------------------------- PR info ------------------------------------
Title      build: do not use bundled simdutf when built with `--shared-simdutf` (#65891)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:shared-simdutf -> nodejs:main
Labels     build, v8 engine, meta, tools, author ready, needs-ci, commit-queue, dont-land-on-v22.x, dont-land-on-v24.x
Commits    3
 - deps: V8: backport a0607c5006b8
 - build: do not use bundled simdutf when built with `--shared-simdutf`
 - tools: clean up handling of shared libs in `shell.nix`
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65891
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65891
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 07 Sep 2026 21:27:15 GMT
   ✔  Approvals: 1
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/65891#pullrequestreview-5136718198
   ✖  This PR needs to wait 84 more hours to land (or 0 minutes if there is one more approval)
   ✖  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-09-10T20:41:34Z: https://ci.nodejs.org/job/node-test-pull-request/77318/
- Querying data for job/node-test-pull-request/77318/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

aduh95 force-pushed the shared-simdutf branch from 4703552 to 775944c Compare September 7, 2026 21:32

This comment was marked as outdated.

Sign in to view

aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 7, 2026

This comment was marked as outdated.

Sign in to view

meixg approved these changes Sep 8, 2026

View reviewed changes

meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026

This comment was marked as outdated.

Sign in to view

aduh95 added 3 commits September 9, 2026 10:43

build: do not use bundled simdutf when built with --shared-simdutf

ad04bee

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

tools: clean up handling of shared libs in shell.nix

f5856b5

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 force-pushed the shared-simdutf branch from 20a9a57 to f5856b5 Compare September 9, 2026 08:50

This comment was marked as duplicate.

Sign in to view

This comment was marked as outdated.

Sign in to view

aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 10, 2026

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 11, 2026

aduh95 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 11, 2026

aduh95 requested a review from joyeecheung September 11, 2026 10:44

Uh oh!

Uh oh!

Conversation

aduh95 commented Sep 7, 2026

Uh oh!

nodejs-github-bot commented Sep 7, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

codecov Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 9, 2026

Uh oh!

nodejs-github-bot commented Sep 9, 2026

Uh oh!

nodejs-github-bot commented Sep 9, 2026

Uh oh!

nodejs-github-bot commented Sep 9, 2026

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

github-actions Bot commented Sep 10, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Sep 10, 2026

Uh oh!

nodejs-github-bot commented Sep 10, 2026

Uh oh!

nodejs-github-bot commented Sep 11, 2026

Commit Queue failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 8, 2026 •

edited

Loading