Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 57.65% 62.76% +5.10%
==========================================
Files 33 32 -1
Lines 1913 1614 -299
==========================================
- Hits 1103 1013 -90
+ Misses 717 600 -117
+ Partials 93 1 -92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AnnaShaleva
reviewed
Aug 11, 2026
Turalchik
force-pushed
the
extend-prepare-request
branch
from
August 12, 2026 17:37
087c01c to
945ab02
Compare
AnnaShaleva
reviewed
Aug 13, 2026
Turalchik
force-pushed
the
extend-prepare-request
branch
2 times, most recently
from
August 19, 2026 16:36
514cc36 to
8ecec1c
Compare
AnnaShaleva
reviewed
Sep 4, 2026
AnnaShaleva
left a comment
AnnaShaleva
left a comment
Member
There was a problem hiding this comment.
Let's align dbft code wrt nspcc-dev/neo-go@ff4eb10. No decoding optimisation is required. Both old (master) and new (feature) behaviour should be preserved, the behaviour switch (something like a configurable callback or an additional parameter to (DBFT).Start or (DBFT).Reset) should be exposed to the external user to enable the extension starting from some point without dBFT shutdown.
Turalchik
force-pushed
the
extend-prepare-request
branch
from
September 8, 2026 08:59
8ecec1c to
dcfb34e
Compare
AnnaShaleva
reviewed
Sep 8, 2026
| MissingTransactions []H | ||
| // Transactions is a map containing actual transactions for the current block. | ||
| // Transactions stores transactions collected so far for the current block, | ||
| // indexed by hash. It's used for pre-Huyao behaviour (FullTransactionsEnabled |
Member
There was a problem hiding this comment.
Remove all Huyao mentions from the dBFT. For the dBFT library it's just an extension that enables new way of PrepareRequest construction. This extension will be used in NeoX network with a different hardfork name. So refer to it as to an extension.
Turalchik
force-pushed
the
extend-prepare-request
branch
4 times, most recently
from
September 9, 2026 17:11
a8774e3 to
eb4f98d
Compare
Turalchik
force-pushed
the
extend-prepare-request
branch
4 times, most recently
from
September 10, 2026 09:38
d59d366 to
22729f1
Compare
AnnaShaleva
reviewed
Sep 10, 2026
AnnaShaleva
left a comment
AnnaShaleva
left a comment
Member
There was a problem hiding this comment.
Should work now. Before the merge you need to finalize the NeoGo part and test the Huyao transition on the running privnet. From my side an integration with NeoX is required, will push the PR soon.
Signed-off-by: Tural Devrishev <tural@nspcc.ru>
Turalchik
force-pushed
the
extend-prepare-request
branch
from
September 11, 2026 08:36
22729f1 to
aa29c57
Compare
AnnaShaleva
reviewed
Sep 14, 2026
Signed-off-by: Tural Devrishev <tural@nspcc.ru>
Turalchik
force-pushed
the
extend-prepare-request
branch
from
September 15, 2026 14:40
aa29c57 to
cd348ce
Compare
AnnaShaleva
reviewed
Sep 15, 2026
AnnaShaleva
left a comment
AnnaShaleva
left a comment
Member
There was a problem hiding this comment.
LGTM, waiting for the NeoX part to settle before the merge.
1. Do not rely on PrepareRequestExtension-disabled-specific Transactions/TransactionHashes fields to detect missing transactions. Instead, use the MissingTransactions map to detect if all transactions are fetched. 2. Change the order of MissingTransactions update and addTransaction call to ensure addTransaction relies on up-to-date MissingTransactions state. Verify other users of MissingTransactions against the similar problem. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Sep 23, 2026
A part of nspcc-dev/neo-go#4325. An alternative to #160. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
3 tasks
AnnaShaleva
added a commit
that referenced
this pull request
Sep 23, 2026
A part of nspcc-dev/neo-go#4325. An alternative to #160. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Sep 24, 2026
1. Replace GetTx with GetTxes. 2. Drop TransactionHashes, convert Transactions to a slice. A part of nspcc-dev/neo-go#4325. An alternative to #160. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
PrepareRequestwithTransactions().NewPrepareRequestnow also receives the full transaction bodies, andprocessMissingTxtakes them as an argument, so a backup can pull a missing transaction straight from the request instead of a network request that may go unanswered. See nspcc-dev/neo-go#4325.