Repository navigation
client: sign container requests with explicit signer - #898
Merged
roman-khimov merged 1 commit intoOct 26, 2026
Merged
Conversation
These cases are special, they require any signature routine to be done by container owner, that is why it is passed as a func param. In particular, it allows nspcc-dev/neofs-node#4245 exchanging container, containerID, and container eACL signatures with the whole request signatures. Refs nspcc-dev/neofs-api#446. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/sign-container-requests-with-explicit-signer
branch
from
October 23, 2026 15:01
39f001b to
df56a08
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 61.34% 61.35%
=======================================
Files 177 177
Lines 17194 17216 +22
=======================================
+ Hits 10548 10563 +15
- Misses 6646 6653 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 23, 2026
It now has container RPC signed by container owner (or by an authorized key) and allows IRs checking original requests by its signatures, not by request fields. Refs nspcc-dev/neofs-api#446, nspcc-dev/neofs-sdk-go#898. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
marked this pull request as ready for review
October 23, 2026 19:04
carpawell
requested review from
cthulhu-rider,
roman-khimov and
smallhive
as code owners
October 23, 2026 19:04
roman-khimov
approved these changes
Oct 26, 2026
roman-khimov
deleted the
fix/sign-container-requests-with-explicit-signer
branch
October 26, 2026 12:45
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 26, 2026
It now has container RPC signed by container owner (or by an authorized key) and allows IRs checking original requests by its signatures, not by request fields. Refs nspcc-dev/neofs-api#446, nspcc-dev/neofs-sdk-go#898. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 27, 2026
It now has container RPC signed by container owner (or by an authorized key) and allows IRs checking original requests by its signatures, not by request fields. Refs nspcc-dev/neofs-api#446, nspcc-dev/neofs-sdk-go#898. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Oct 27, 2026
It now has container RPC signed by container owner (or by an authorized key) and allows IRs checking original requests by its signatures, not by request fields. Refs nspcc-dev/neofs-api#446, nspcc-dev/neofs-sdk-go#898. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These cases are special, they require any signature routine to be done by container owner, that is why it is passed as a func param. In particular, it allows nspcc-dev/neofs-node#4245 exchanging container, containerID, and container eACL signatures with the whole request signatures. Refs nspcc-dev/neofs-api#446.