Skip to content

fix(layer): keep footer within viewport on short pages - #1471

Merged
larbish merged 1 commit into
mainfrom
fix/layout-height
Oct 20, 2026
Merged

larbish merged 1 commit into
mainfrom
fix/layout-height

Conversation

@larbish

@larbish larbish commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Resolves #1330

UMain's default min-h-[calc(100vh-var(--ui-header-height))] ignores the footer, so every short page was 100vh + footer height and always scrolled.

  • Make the app wrapper a flex flex-col min-h-svh column and let UMain grow with flex-1 min-h-auto in the default and docs layouts
  • Apply the same layout to error.vue (UError had the same min-height issue)

🤖 Generated with Claude Code, reviewed by @larbish before opening.

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docus Ready Ready Preview Oct 20, 2026 9:35am UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/create-docus@1471
npm i https://pkg.pr.new/docus@1471

commit: 4830050

@docus-bundle-report

Copy link
Copy Markdown

Production bundle

Comparing fcc228ca with 4830050e. Compressed sizes are calculated from the emitted production assets.

Initial page load

Page Base JS (Brotli) PR JS (Brotli) Δ JS Δ CSS Δ files
/en 499.7 KiB 499.8 KiB +176 B (+0.0%) +68 B (+0.3%) —
/en/getting-started/installation 278.6 KiB 278.8 KiB +187 B (+0.1%) +68 B (+0.3%) —
/en/essentials/components 293.0 KiB 293.1 KiB +187 B (+0.1%) +68 B (+0.3%) —

Entry script, modulepreload chunks and stylesheets referenced by the prerendered HTML. Lazy and prefetched chunks are excluded.

All client assets

Metric Base (Brotli) PR (Brotli) Δ Brotli Δ gzip
Client JavaScript 847.8 KiB 848.0 KiB +145 B (+0.0%) +55 B (+0.0%)
Client CSS 25.2 KiB 25.3 KiB +68 B (+0.3%) +10 B (+0.0%)
Other client assets 339.4 KiB 339.4 KiB — +3 B (+0.0%)
Total client assets 1.18 MiB 1.18 MiB +213 B (+0.0%) +68 B (+0.0%)

Largest module increases

Module Base (Brotli) PR (Brotli) Δ Brotli
layer/app/error.vue?vue&type=script&setup=true&lang.ts 1.0 KiB 1.1 KiB +56 B (+5.3%)
layer/app/layouts/docs.vue?vue&type=script&setup=true&lang.ts 632 B 659 B +27 B (+4.3%)
layer/app/app.vue?vue&type=script&setup=true&lang.ts 1.4 KiB 1.4 KiB +12 B (+0.8%)
layer/app/layouts/default.vue 238 B 250 B +12 B (+5.0%)

Module values come from Nuxt’s analyzer and are attribution estimates. This workflow is currently report-only.

Workflow run

@larbish
larbish merged commit 57feec7 into main Oct 20, 2026
14 checks passed
@larbish
larbish deleted the fix/layout-height branch October 20, 2026 10:04

This branch was successfully deployed

1 active deployment
Preview — 4830050e Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The min-height of the main content does not include footer height in the calculation

1 participant