Repository navigation
Fix the Release workflow failing on its source-archive check - #2
Conversation
The v0.1.2 tag's Release run failed before building anything: in `gzip -dc archive | git get-tar-commit-id`, get-tar-commit-id reads only the tar header and exits, gzip then hits a broken pipe, and the step's `bash -e -o pipefail` turns that into a failure (exit 141). Decompress to a file first. Reproduced and verified against the real v0.1.2 archive under the runner's exact shell options: the archive is commit 3bc3879 and both recipes pin to 0.1.2-1. Same latent pattern in verify-pacman-client.sh (`pacman -Qi | grep -q`): capture the output first. No tag is moved: the existing v0.1.2 is rebuilt by dispatching this workflow from main with tag=v0.1.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow now reads an archive commit ID from a decompressed temporary file. The pacman client verifier now uses one package information query for both displayed metadata and signature validation. ChangesRelease archive verification
Pacman client verification
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The release archive check and both package-verification paths retain their required checks. No actionable merge risk is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The
v0.1.2tag's Release run (run 37024695621) failed in its first job, before building or releasing anything.In
gzip -dc archive | git get-tar-commit-id,get-tar-commit-idreads only the tar header and exits.gzipthen hits a broken pipe, and the step'sbash -e -o pipefailturns that into a failure (exit 141). The fix decompresses to a file first.verify-pacman-client.shhad the same latent pattern (pacman -Qi | grep -q); it now captures the output first.No tag is moved. After merging, the existing
v0.1.2is rebuilt by dispatchingrelease.ymlfrommainwithtag=v0.1.2, thenpublish-repos.ymlthe same way.Test plan
bash --noprofile --norc -e -o pipefail) in a clean Ubuntu container: the old line exits 141. The fixed step passes against the realv0.1.2archive: the archive is commit3bc3879, and both recipes pin to0.1.2-1with sha2562c6408e8…881e.🤖 Generated with Claude Code
Summary by CodeRabbit