Repository navigation
feat(desktop): add observation navigation and unify feedback and context - #2188
Open
sunlight798 wants to merge 9 commits into
Open
sunlight798 wants to merge 9 commits into
sunlight798 wants to merge 9 commits into
Conversation
Keep Overview as the initial page and Settings & diagnostics at the bottom of the sidebar. Add Observation without changing the existing page content.
sunlight798
requested review from
AlexStocks,
PsiACE and
frostming
as code owners
October 22, 2026 05:28
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #2102.
Rationale for this change
Desktop needs consistent navigation, feedback and recovery guidance, with the current connection and exact Scope visible across pages. These improvements must preserve existing workflows and protect drafts when asynchronous connection, Scope and write results arrive.
Packaged macOS testing also exposed navigation-origin and confirmation-dialog issues that prevented reliable use of the shared shell.
What changes are included in this PR?
tauri://localhoston macOS, while retaining navigation restrictions.Observation data integrations remain explicitly unavailable pending #2105, #2106 and #2107. Server installation and lifecycle management remain owned by #2117.
Are there any user-facing changes?
Yes. Users gain Observation navigation, clearer global context, consistent recovery guidance, help and local setup entry points, and reliable application confirmations on macOS.
Existing connection, Scope, Memory and diagnostic workflows remain accessible. Language and theme changes preserve drafts. Selecting a saved profile opens its editor without activating it, and Observation navigation does not trigger connection checks.
There are no changes to public HTTP APIs, IPC command schemas, credential formats or persisted data formats. No migration is required.
How was this change tested?
Validation is recorded in
desktop/VALIDATION.md, using Node 24.14.1, pnpm 11.13.1 and Rust 1.95.0.Passed checks:
Generated contracts and icons were checked without regeneration.
Regression coverage includes navigation, bilingual feedback, exact Scope identity, targeted profile selection, draft cancellation, pending context changes, late responses, failed and unknown writes, confirmation dialogs and keyboard focus.
Windows headless Edge checks with synthetic IPC covered English/Chinese, light/dark/system themes, narrow windows, 800×600 layouts, error states and forced colors. The 200% layout check used an equivalent viewport; it was not native WebView zoom acceptance.
On macOS 26.5.1 Apple Silicon, a debug application was built with:
The packaged application loaded without Vite, and native state/version IPC worked. Actual WebView checks covered bilingual draft navigation, cancel-editing confirmations, explicit discard, Escape cancellation, Tab/Shift+Tab containment and Scope-dialog focus restoration.
Packaged macOS checks did not use a real Server. Signing/notarization, Intel Mac, IME, VoiceOver, native 200% zoom, Keychain and installed Server workflows remain unqualified.
Repository-wide
uv run --locked prek run -aencountered existing Windows Python type-check failures in unchanged code; the other hooks passed.AI usage statement
OpenAI Codex assisted with implementation, regression tests, documentation and review.