Repository navigation
types: make ChatRequest serialization None-safe for tools without parameters - #755
Open
DeepanshuPal wants to merge 2 commits into
Open
DeepanshuPal wants to merge 2 commits into
DeepanshuPal wants to merge 2 commits into
Conversation
… parameters Add tests for ChatRequest serialization with tools and parameters.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatRequest.serialize_model assumed every serialized tool has a function with a parameters mapping. A Tool with no function, or a Function with no parameters, made model_dump() and model_dump_json() raise PydanticSerializationError unless exclude_none=True was passed. The serializer now skips tools that have no parameters, and the defs to $defs rename still applies when parameters is present. Adds tests for both cases. Fixes #733.
Note: an earlier fix (#736) was closed unmerged by its author; this is a fresh take with tests covering both missing function and missing parameters.