Loosen the offline Node pin so mise up tracks new releases - #11656
Merged
Merged
Conversation
Offline installs unpack the bundled tarball and pin Node to its exact version, since latest can't be resolved without network. But nothing ever loosened that pin, so Node stayed frozen at the ISO's version and mup skipped it forever, while online installs tracked latest. Rewrite the pin to latest right after registering the bundled version: mise resolves latest to the installed version while offline (verified with no network and an empty cache), and the first mise up with network picks up new releases just like an online install. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017LseZ1jcLaFBnndRnW4yb5
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline installs (ISO chroot and provision-owner) unpack the bundled Node tarball and run
mise use -g node@$NODE_VERSION, which writes an exact pin likenode = "26.7.0"into the global mise config. That's necessary at install time —latestcan't be resolved without network — but nothing ever loosened it afterward. The result: every offline-installed machine has Node frozen at the ISO's version and silently exempt frommup/mise up, while online installs writenode = "latest"and track new releases.The fix rewrites the pin to
latestright after registering the bundled version. Verified that this is safe for offline installs: with networking blocked (unshare -rn) and an empty mise cache,node = "latest"still resolves to the installed version — activation,mise x, andbin-pathsall work. The firstmise upwith network then picks up new releases exactly like an online install.🤖 Generated with Claude Code
https://claude.ai/code/session_017LseZ1jcLaFBnndRnW4yb5