Conversation
The sublime-text-4 package installs its launcher as /usr/bin/subl, but the default-editor flow stored and probed sublime_text. That command is never on PATH, so choosing Sublime Text re-triggered the install flow on every selection, and a stored default fell back to Neovim at launch. Older state files still carry sublime_text; both readers map it forward so an existing choice keeps working. Fixes omacom#11039 Fixes omacom#10800 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT
Member
|
Automated duplication check: this pull request looks similar to #9656, which covers the same Sublime subl default. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sublime-text-4package installs its launcher as/usr/bin/subl(PKGBUILD), but the default-editor flow stored and probedsublime_text. That command is never onPATH, so choosing Sublime Text re-triggered the install flow on every selection, and a stored default fell back to Neovim at launch.Older state files still carry
sublime_text; both readers map it forward so an existing choice keeps working. Same shape as #11344 does for Zed.Fixes #11039
Fixes #10800
Testing
test/shell.d/default-apps-test.shupdated (the mock installer now providessubl) plus a legacy-state assertion;bin-style-test.shpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT