Conversation
KDE Connect escapes the title and body it relays from a phone before handing them to KNotification, and they reach the shell escaped a second time: a quotation mark arrives as &quot;, StyledText decodes one layer, and the card shows ". WhatsApp reaction notifications made this visible on every message. Undo that one layer for KDE Connect only, and only for & ahead of another entity, so the text is left escaped exactly once and the rewrite can never manufacture markup the image stripper did not see. Fixes omacom#11059 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT
Member
|
Automated duplication check: this pull request looks similar to #11155, which covers the same notification entity decode. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KDE Connect escapes the title and body it relays from a phone before handing them to KNotification, and they reach the shell escaped a second time: a quotation mark arrives as
&quot;, StyledText decodes one layer, and the card shows". WhatsApp reaction notifications made this visible on every message.Undo that one layer for KDE Connect only, and only for
&ahead of another entity, so the text is left escaped exactly once and the rewrite can never manufacture markup the image stripper did not see.Fixes #11059
Testing
Seven assertions added to
test/shell.d/notifications-test.sh: detection by name and icon, the report's exact body, a body with</>/numeric entities staying escaped once, a bare&left alone, and other apps untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_01LKJ7WaM8LCBtL91KJe3wQT