Skip to content

Fix spelling and grammer issues + add CI detection - #501

Open
rwmcguir wants to merge 2 commits into
oneapi-src:masterfrom
rwmcguir:gh-issue-424
Open

Fix spelling and grammer issues + add CI detection#501
rwmcguir wants to merge 2 commits into
oneapi-src:masterfrom
rwmcguir:gh-issue-424

Conversation

@rwmcguir

@rwmcguir rwmcguir commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • Fix spelling errors
  • Add CI detection and posting to comments
  • Add one error so we can see the CI work, and will remove before merging.

@rwmcguir rwmcguir linked an issue Jul 30, 2026 that may be closed by this pull request
@rwmcguir
rwmcguir requested a review from nrspruit July 30, 2026 23:20
@rwmcguir
rwmcguir force-pushed the gh-issue-424 branch 4 times, most recently from 9199706 to b4587b5 Compare July 30, 2026 23:54
@rwmcguir rwmcguir self-assigned this Jul 31, 2026
+ Also remove node 20 deprecation for checkout@v4 GH actions

Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily standardizes spelling/grammar across loader, validation layer, headers, docs, and templates, and introduces a CI spell-checking signal (codespell) that can surface findings inline and via an automated PR comment. It also updates several GitHub Actions workflows to use actions/checkout@v5.

Changes:

  • Fixes numerous spelling/grammar issues across C/C++ sources/headers, Python bindings, docs, templates, and changelog entries.
  • Adds a Codespell CI workflow and a companion workflow_run workflow to post/update a PR comment with the report.
  • Updates multiple existing workflows to use actions/checkout@v5 and improves token handling in update-spec.yml.

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
test/CMakeLists.txt Fixes spelling in test comment.
source/loader/zes_ldrddi.h Fixes typos in API comments.
source/loader/zes_ldrddi.cpp Fixes typos in API comments.
source/loader/zes_ldrddi_driver_ddi.cpp Fixes typos in API comments.
source/loader/ze_loader.cpp Fixes spelling in loader comment.
source/loader/ze_loader_internal.h Fixes spelling in enum documentation.
source/loader/ze_ldrddi.cpp Fixes spelling in comments.
source/lib/zet_libapi.cpp Fixes typo in API documentation.
source/lib/zes_libapi.cpp Fixes typos in API comments.
source/lib/ze_libapi.cpp Fixes typos in API documentation.
source/layers/validation/zes_valddi.cpp Fixes typos in validation-layer comments.
source/layers/validation/README.md Fixes typo in README heading.
source/layers/validation/handle_lifetime_tracking/zes_handle_lifetime.cpp Fixes typos in prologue comments.
source/layers/validation/CONTRIBUTING.md Fixes typo in contributor doc.
source/layers/validation/checkers/parameter_validation/zes_parameter_validation.cpp Fixes typos in parameter-validation prologue comments.
source/layers/validation/checkers/events_checker/zel_events_checker.cpp Fixes typos in checker comments/parameter docs.
source/layers/validation/checkers/basic_leak/zel_basic_leak_checker.cpp Fixes typo in comment.
source/drivers/null/zes_nullddi.cpp Fixes typos in null driver DDI comments.
scripts/templates/ze_loader_internal.h.mako Keeps template comments aligned with header spelling fixes.
scripts/templates/validation/handle_lifetime.cpp.mako Fixes typo in generator comment.
scripts/templates/ldrddi.cpp.mako Fixes typos in generator comments.
scripts/templates/helper.py Fixes typos in helper docstrings/comments.
README.md Fixes spelling in project README.
include/zet.py Fixes spelling in Python binding comments.
include/zet_api.h Fixes typos in public header docs.
include/zes.py Fixes multiple typos in Python binding comments/docs.
include/zes_api.h Fixes typos in public header docs.
include/ze.py Fixes typos in Python binding comments/docs.
include/ze_api.h Fixes typos in public header docs.
include/layers/zel_tracing_api.h Fixes typo in comment.
doc/loader_api.md Fixes typos in loader API documentation.
CHANGELOG.md Fixes spelling in changelog entries.
bindings/sysman/python/source/pyzes.py Fixes typo in Python binding source comment.
.github/workflows/update-spec.yml Updates checkout action version and token fallback handling.
.github/workflows/scorecard.yml Updates checkout action version.
.github/workflows/codespell.yml Adds codespell PR workflow producing annotations + artifact report.
.github/workflows/codespell-comment.yml Adds workflow-run job to post/update PR comment from codespell artifact.
.github/workflows/check-abi.yml Updates checkout action versions.
.github/workflows/build-quick.yml Updates checkout action version.
.github/workflows/build-quick-static.yml Updates checkout action version.
.github/workflows/build-quick-static-n-1.yml Updates checkout action versions.
.github/workflows/build-multi.yml Updates checkout action versions.
.github/workflows/build-multi-static.yml Updates checkout action versions.
.github/workflows/build-msi-package.yml Updates checkout action version.
.github/workflows/build-clang.yml Updates checkout action version.
.github/workflows/bindings-sysman-python-unit-tests-coverage.yml Updates checkout action version.
.github/workflows/bindings-sysman-python-security-scan.yml Updates checkout action version.
.github/workflows/bindings-sysman-python-checks.yml Updates checkout action version.
.codespellrc Adds codespell configuration (skip list + ignore words).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to +21
permissions:
contents: read
pull-requests: write
Comment thread include/zes.py
##
## @details
## - This not a universal identifier. The identified is garanteed to be
## - This not a universal identifier. The identified is guaranteed to be
Comment thread include/zes_api.h
///
/// @details
/// - This not a universal identifier. The identified is garanteed to be
/// - This not a universal identifier. The identified is guaranteed to be
Comment thread include/ze.py
Comment on lines 5489 to +5490
## device. It important to note that usable memory size reported is
## transient in nature and cannot be used to reliably guarentee success
## transient in nature and cannot be used to reliably guarantee success
Comment thread include/ze_api.h
Comment on lines 16458 to +16459
///< device. It important to note that usable memory size reported is
///< transient in nature and cannot be used to reliably guarentee success
///< transient in nature and cannot be used to reliably guarantee success
Comment thread CHANGELOG.md
* Remove SPDLog from project entirely
* Add New custom C++ smaller Logger, to replace SPDLog
* Add future Enhancements to new Logger with available with expiremental =2 settings
* Add future Enhancements to new Logger with available with experimental =2 settings
Comment thread CHANGELOG.md
## v1.28.6
* Remove level-zero* (non-Canonical) package names when building DEBs with CPack
* Allow pkgconfig file isntallation with Window MSI Installer
* Allow pkgconfig file installation with Window MSI Installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typos visible in the code, and the documentation generated from it

2 participants