Repository navigation
fix(runner): disable Expect: 100-continue on requests to runtimes - #258
Open
HarshMN2345 wants to merge 1 commit into
Open
HarshMN2345 wants to merge 1 commit into
HarshMN2345 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcurl adds `Expect: 100-continue` to request bodies over 1 MiB and then waits up to 1 s for a `100 Continue` that the runtimes never send, so every execution with a body above 1 MiB takes an extra second. This sends an empty `Expect:` header in `executeV5`, `executeV2` and the internal create-runtime request.
Refs appwrite/appwrite#14095
Verification (executor base image, libcurl 8.17, Swoole hooks, executeV5 curl options against a server that doesn't answer 100-continue):
`composer analyze`, pint, rector and unit tests pass.