Skip to content

fix(runner): disable Expect: 100-continue on requests to runtimes - #258

Open
HarshMN2345 wants to merge 1 commit into
mainfrom
fix/disable-expect-100-continue
Open

HarshMN2345 wants to merge 1 commit into
mainfrom
fix/disable-expect-100-continue

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

libcurl adds `Expect: 100-continue` to request bodies over 1 MiB and then waits up to 1 s for a `100 Continue` that the runtimes never send, so every execution with a body above 1 MiB takes an extra second. This sends an empty `Expect:` header in `executeV5`, `executeV2` and the internal create-runtime request.

Refs appwrite/appwrite#14095

Verification (executor base image, libcurl 8.17, Swoole hooks, executeV5 curl options against a server that doesn't answer 100-continue):

Body before after
1.0 MB 0.003 s 0.002 s
1.5 MB 1.007 s 0.002 s
5.0 MB 1.021 s 0.003 s

`composer analyze`, pint, rector and unit tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant