Repository navigation
fix(runner): reuse connections to runtimes across executions - #259
Open
HarshMN2345 wants to merge 1 commit into
Open
HarshMN2345 wants to merge 1 commit into
HarshMN2345 wants to merge 1 commit into
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executor opened a new connection to the runtime for every execution (
curl_init()per call). Under load the closed connections pile up inTIME_WAITin the executor's network namespace,connect()gets expensive and eventually fails withEADDRNOTAVAIL.This keeps idle curl handles per runtime hostname in each worker and reuses them (
curl_reset()keeps the open connection), for v2 and v5 executions. A handle is only returned to the pool after a successful request, at most 128 are kept per runtime, and handles of runtimes not used for 60 s are closed. Runtime hostnames are random per runtime, so a recreated runtime never gets an old connection, and libcurl replaces connections that the runtime closed (tested with a runtime restart).A shared connection cache (
curl_share_init_persistentwithCURL_LOCK_DATA_CONNECT) doesn't work here: Swoole's curl hook runs eachcurl_exec()in its own multi handle, which keeps at most 4 connections, and moving sockets between multi handles crashed Swoole under load.Refs appwrite/appwrite#14094
Verification: real
createExecution()against a keep-alive runtime stand-in, 20000 executions with 100 coroutines, 4 runs back to back:Unit tests, phpstan, pint and rector pass.