Skip to content

What is the purpose of SmearGate cross-document 'leak fix'? #1988

Description

@ClassicLarry

Why are PRs, such as the current record #1855, doing this?

Looking at prior documents does not break causality. Any LLM that doesn't use intra-document masking is already looking at prior documents through attention. There is no 'cheating' involved here, unless the maintainers have created an arbitrary ruling on this. When all of these 1 position techniques like smear gate and bigram hash were created, both the masked and unmasked versions were tested, and the unmasked version was intentionally selected because it ran faster, didn't hurt loss, and obeyed the causal mask.

I am concerned that every record is going to copy paste this, and the final record is going to have this janky inefficiency for no good reason.

Activity

  1. ClassicLarry commented on Apr 30, 2026

    @ClassicLarry
    Author

    I see CocoHearts mentioned its a ruling here: #1797 (comment).

    This is surprising to me. For anyone using these techniques in their own repos on small models, I would not recommend paying the extra compute cost to mask. Looks like in parameter golf this is a custom rule.

  2. andrewbaggio1 commented on Apr 30, 2026

    @andrewbaggio1

    yeah it's interesting

  3. romeerp commented on Apr 30, 2026

    @romeerp
    Contributor

    agreed - it looks to me honestly like something mis-identified through some sort of auto-audit flagging data leakage, which has been a problem with a ton of PRs here, but obviously seeing a prior token doesn't constitute any form of leakage.

  4. MarioPaerle commented on Apr 30, 2026

    @MarioPaerle
    Contributor

    Actually I felt the exact same about the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions