Repository navigation
Conversation
|
|
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Preserve the parameter source for missing body fields and add body regression coverage.
Review effort: Lite
Findings: None
What changed in this PR
This PR updates API validation so missing fetcher parameters return HTTP 422 instead of 500.
Changes:
- Adjusts missing-field validation handling.
- Adds regression coverage for missing
category.
| File | Summary |
|---|---|
openbb_platform/core/tests/api/test_exception_handlers.py |
Adds regression coverage for missing fetcher parameters. |
openbb_platform/core/openbb_core/api/exception_handlers.py |
Updates validation-error classification. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bozarnr
force-pushed
the
fix/fetcher-validation-status
branch
from
October 15, 2026 18:12
48fe1cd to
8d33c12
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7629. Maps missing required fields from fetcher QueryParams validation to HTTP 422 and adds a focused regression test. Tests: pytest targeted regression; ruff targeted files.