Skip to content

Remove project-url-shortener/db in favor of OpenChoreo's postgres CRT - #25

Open
adibmbrk wants to merge 1 commit into
openchoreo:mainfrom
adibmbrk:remove-postgres-build-from-source
Open

Remove project-url-shortener/db in favor of OpenChoreo's postgres CRT#25
adibmbrk wants to merge 1 commit into
openchoreo:mainfrom
adibmbrk:remove-postgres-build-from-source

Conversation

@adibmbrk

@adibmbrk adibmbrk commented Aug 25, 2026

Copy link
Copy Markdown

Summary

  • OpenChoreo's url-shortener samples (both from-image and from-source) now provision Postgres as a Resource off the shipped postgres ClusterResourceType, using its initSQL parameter to seed the urls/clicks schema, instead of building this repo's custom Postgres image.
  • Removes project-url-shortener/db entirely (Dockerfile, init.sql, workload.yaml) — no longer referenced by any OpenChoreo sample.
  • docker-compose.yaml's postgres service now runs a stock postgres:15-alpine image instead of build: ./db.

Breaking change for local dev

Removing init.sql means docker compose up no longer auto-creates the urls/clicks schema. Anyone running this locally will need to apply the schema manually (e.g. psql against the compose Postgres) until/unless the services themselves run migrations on startup.

Test plan

  • docker compose up --build in project-url-shortener brings up Postgres (schema now needs to be applied manually — see above)

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7abc4437-cc3f-4de4-9dc5-d6a207c021ad


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

OpenChoreo's url-shortener samples (both from-image and from-source)
now provision Postgres as a Resource off the shipped postgres
ClusterResourceType, seeding the urls/clicks schema via its initSQL
parameter instead of building this repo's custom Postgres image, so
the db directory is no longer referenced by any OpenChoreo sample.

docker-compose's postgres service now runs a stock postgres:15-alpine
image with no init step; local docker compose up no longer seeds the
schema automatically.
@adibmbrk
adibmbrk force-pushed the remove-postgres-build-from-source branch from 0791259 to 0dbd26e Compare August 25, 2026 15:49
@adibmbrk adibmbrk changed the title Remove postgres Dockerfile build in favor of OpenChoreo's postgres CRT Remove project-url-shortener/db in favor of OpenChoreo's postgres CRT Aug 25, 2026
adibmbrk added a commit to adibmbrk/openchoreo that referenced this pull request Aug 25, 2026
Mirrors the from-image variant: Postgres is now provisioned as a
Resource off the postgres ClusterResourceType (schema seeded via
initSQL) instead of a Component built from sample-workloads'
project-url-shortener/db, which no longer exists
(openchoreo/sample-workloads#25). api-service.yaml/analytics-service.yaml
already referenced dependencies.resources[ref: snip-postgres] so no
change was needed there.
adibmbrk added a commit to adibmbrk/openchoreo that referenced this pull request Aug 25, 2026
Mirrors the from-image variant: Postgres is now provisioned as a
Resource off the postgres ClusterResourceType (schema seeded via
initSQL) instead of a Component built from sample-workloads'
project-url-shortener/db, which no longer exists
(openchoreo/sample-workloads#25). api-service.yaml/analytics-service.yaml
already referenced dependencies.resources[ref: snip-postgres] so no
change was needed there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant