Remove project-url-shortener/db in favor of OpenChoreo's postgres CRT - #25
Open
adibmbrk wants to merge 1 commit into
Open
Remove project-url-shortener/db in favor of OpenChoreo's postgres CRT#25adibmbrk wants to merge 1 commit into
adibmbrk wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenChoreo's url-shortener samples (both from-image and from-source) now provision Postgres as a Resource off the shipped postgres ClusterResourceType, seeding the urls/clicks schema via its initSQL parameter instead of building this repo's custom Postgres image, so the db directory is no longer referenced by any OpenChoreo sample. docker-compose's postgres service now runs a stock postgres:15-alpine image with no init step; local docker compose up no longer seeds the schema automatically.
adibmbrk
force-pushed
the
remove-postgres-build-from-source
branch
from
August 25, 2026 15:49
0791259 to
0dbd26e
Compare
adibmbrk
added a commit
to adibmbrk/openchoreo
that referenced
this pull request
Aug 25, 2026
Mirrors the from-image variant: Postgres is now provisioned as a Resource off the postgres ClusterResourceType (schema seeded via initSQL) instead of a Component built from sample-workloads' project-url-shortener/db, which no longer exists (openchoreo/sample-workloads#25). api-service.yaml/analytics-service.yaml already referenced dependencies.resources[ref: snip-postgres] so no change was needed there.
adibmbrk
added a commit
to adibmbrk/openchoreo
that referenced
this pull request
Aug 25, 2026
Mirrors the from-image variant: Postgres is now provisioned as a Resource off the postgres ClusterResourceType (schema seeded via initSQL) instead of a Component built from sample-workloads' project-url-shortener/db, which no longer exists (openchoreo/sample-workloads#25). api-service.yaml/analytics-service.yaml already referenced dependencies.resources[ref: snip-postgres] so no change was needed there.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
url-shortenersamples (both from-image and from-source) now provision Postgres as aResourceoff the shippedpostgresClusterResourceType, using itsinitSQLparameter to seed theurls/clicksschema, instead of building this repo's custom Postgres image.project-url-shortener/dbentirely (Dockerfile,init.sql,workload.yaml) — no longer referenced by any OpenChoreo sample.docker-compose.yaml'spostgresservice now runs a stockpostgres:15-alpineimage instead ofbuild: ./db.Breaking change for local dev
Removing
init.sqlmeansdocker compose upno longer auto-creates theurls/clicksschema. Anyone running this locally will need to apply the schema manually (e.g.psqlagainst the compose Postgres) until/unless the services themselves run migrations on startup.Test plan
docker compose up --buildinproject-url-shortenerbrings up Postgres (schema now needs to be applied manually — see above)