Skip to content

Add null checks to methods of Block.Builder and Body.Builder. - #1104

Open
mabbay wants to merge 3 commits into
openjdk:code-reflectionfrom
mabbay:null-check-in-builders
Open

Add null checks to methods of Block.Builder and Body.Builder.#1104
mabbay wants to merge 3 commits into
openjdk:code-reflectionfrom
mabbay:null-check-in-builders

Conversation

@mabbay

@mabbay mabbay commented Jul 16, 2026

Copy link
Copy Markdown
Member

Add null checks to methods of Block.Builder and Body.Builder. The null checks take precedence over finished building checks.



Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1104/head:pull/1104
$ git checkout pull/1104

Update a local copy of the PR:
$ git checkout pull/1104
$ git pull https://git.openjdk.org/babylon.git pull/1104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1104

View PR using the GUI difftool:
$ git pr show -t 1104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1104.diff

Using Webrev

Link to Webrev Comment

@mabbay
mabbay requested a review from PaulSandoz July 16, 2026 22:03
@mabbay mabbay self-assigned this Jul 16, 2026
@bridgekeeper

bridgekeeper Bot commented Jul 16, 2026

Copy link
Copy Markdown

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add null checks to methods of Block.Builder and Body.Builder.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the code-reflection branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2026
@mlbridge

mlbridge Bot commented Jul 16, 2026

Copy link
Copy Markdown

Webrevs

@mabbay

mabbay commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

I found a similar case in method public CodeBuilder jdk.internal.classfile.impl.BufferedCodeBuilder#with(CodeElement element), there the order of the checks is status first then null.

@mabbay
mabbay requested a review from mcimadamore July 24, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant