Skip to content

8612: Update the lz4-java dependency - #726

Closed
thegreystone wants to merge 2 commits into
openjdk:masterfrom
thegreystone:8612-lz
Closed

8612: Update the lz4-java dependency#726
thegreystone wants to merge 2 commits into
openjdk:masterfrom
thegreystone:8612-lz

Conversation

@thegreystone

@thegreystone thegreystone commented Aug 14, 2026

Copy link
Copy Markdown
Member

Might want to backport.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8612: Update the lz4-java dependency (Bug - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/726/head:pull/726
$ git checkout pull/726

Update a local copy of the PR:
$ git checkout pull/726
$ git pull https://git.openjdk.org/jmc.git pull/726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 726

View PR using the GUI difftool:
$ git pr show -t 726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/726.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 14, 2026

Copy link
Copy Markdown

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 14, 2026

Copy link
Copy Markdown

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8612: Update the lz4-java dependency

Reviewed-by: aharmaz, aptmac

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@aymane-harmaz aymane-harmaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the lz4-java version in these two files also be bumped to 1.11.1?

  • jmc/license/THIRDPARTYREADME.txt
  • jmc/core/license/THIRD_PARTY_LICENSES.txt

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@thegreystone Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@thegreystone

Copy link
Copy Markdown
Member Author

Yup. Fixed!

@aymane-harmaz aymane-harmaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the jcheck failure is caused by a missing final period at the end of the OpenJDK Interim AI Policy confirmation in the PR description.

@thegreystone

Copy link
Copy Markdown
Member Author

I think the jcheck failure is caused by a missing final period at the end of the OpenJDK Interim AI Policy confirmation in the PR description.

Doh. Thanks for noticing! :)

@mlbridge

mlbridge Bot commented Aug 20, 2026

Copy link
Copy Markdown

Webrevs

@thegreystone

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented Aug 20, 2026

Copy link
Copy Markdown

Going to push as commit 98f3831.

@openjdk openjdk Bot added the integrated label Aug 20, 2026
@openjdk openjdk Bot closed this Aug 20, 2026
@openjdk

openjdk Bot commented Aug 20, 2026

Copy link
Copy Markdown

@thegreystone Pushed as commit 98f3831.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants