8612: Update the lz4-java dependency - #726
Conversation
|
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
|
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
aymane-harmaz
left a comment
There was a problem hiding this comment.
Shouldn't the lz4-java version in these two files also be bumped to 1.11.1?
- jmc/license/THIRDPARTYREADME.txt
- jmc/core/license/THIRD_PARTY_LICENSES.txt
|
@thegreystone Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Yup. Fixed! |
aymane-harmaz
left a comment
There was a problem hiding this comment.
I think the jcheck failure is caused by a missing final period at the end of the OpenJDK Interim AI Policy confirmation in the PR description.
Doh. Thanks for noticing! :) |
|
/integrate |
|
Going to push as commit 98f3831. |
|
@thegreystone Pushed as commit 98f3831. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Might want to backport.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/726/head:pull/726$ git checkout pull/726Update a local copy of the PR:
$ git checkout pull/726$ git pull https://git.openjdk.org/jmc.git pull/726/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 726View PR using the GUI difftool:
$ git pr show -t 726Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/726.diff
Using Webrev
Link to Webrev Comment