Repository navigation
Trivial fix: initialize argi in tsfile.c - #146
Merged
throwaway96 merged 1 commit intoAug 5, 2026
Merged
Conversation
Initialize positional argument index to zero.
There was a problem hiding this comment.
Pull request overview
Fixes an uninitialized local variable in src/tools/tsfile.c that tracks the positional (non-flag) argument index, preventing undefined behavior when parsing command-line arguments for the tsfile tool.
Changes:
- Initialize
argito0before it is used inswitch(argi++)while parsing positional arguments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tsfile.c, the positional argument index (argi) was not initialized before use.Really,
int argicould be replaced with abool. But I suppose this preserves flexibility in case more positional arguments are added.