Repository navigation
O3-5760: Accept timezone-qualified dates in queue entry searches - #121
Merged
NethmiRodrigo merged 2 commits intoAug 27, 2026
Merged
Conversation
3 tasks done
NethmiRodrigo
left a comment
NethmiRodrigo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @UjjawalPrabhat! A couple of suggestions -
- A blank date param (e.g. ?startedOnOrAfter=) now raises a 400 rather than silently dropping the filter and returning everything. - parseDate takes the parameter name and rethrows ConversionException with it, so a request carrying several date params says which one failed. - Cover startedOn and endedOn, which moved to the new parser too, plus the blank case next to the unparseable one.
|
NethmiRodrigo
approved these changes
Aug 27, 2026
NethmiRodrigo
left a comment
NethmiRodrigo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @UjjawalPrabhat!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From #2615: scoping the average-wait-time card to "today" meant sending
startedOnOrAfter, but there was no way to say which midnight — the parser used a bareSimpleDateFormat("yyyy-MM-dd HH:mm:ss"), which carries no offset and throws on anything else. Clients were left guessing the server's timezone, and a browser ahead of the server silently hid the whole morning.Now parsed with
ConversionUtil.convert(String, Date.class), the same callEncounterSearchHandler2_0andVisitResource1_9use upstream, so a client can send an instant and let the server resolve it.Worth Noting:
ConversionUtilstill accepts the old zone-less form, so existing clients are unaffected (there's a test pinning it).ConversionExceptionis annotated@ResponseStatus(BAD_REQUEST).Related Issue
O3-5760
Other
Frontend counterpart: #2615.