MCO-1736: Promote ImageModeStatusReporting feature gate to default

[isabella-janssen]

Opening as a draft to monitor component readiness score.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Opening as a draft to monitor component readiness score.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 18f3a5af-71c9-4311-928e-9ac698e70dee

📥 Commits

Reviewing files that changed from the base of the PR and between 9d7eaab and fff5a74.

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (6)

• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

📝 Walkthrough

Walkthrough

ImageModeStatusReporting is enabled for default and OKD environments in the feature-gate definition. The feature matrix marks it enabled across all listed contexts. HyperShift and SelfManagedHA default and OKD release manifests move it from disabled gates to enabled gates.

Possibly related PRs

• openshift/api#2915: Promotes another feature gate across the same declarations and release manifests.
• openshift/api#2964: Promotes another feature gate across the same registration and manifest locations.

Suggested reviewers: everettraven, joelspeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the promotion of the ImageModeStatusReporting feature gate to the default configuration.
Description check	✅ Passed	The description relates to the pull request by stating that it monitors component readiness for the feature-gate promotion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes feature-gate source, documentation, and YAML manifests only; no Ginkgo test titles or dynamic values were added.
Test Structure And Quality	✅ Passed	The HEAD^..HEAD diff changes only feature-gate Go, Markdown, and YAML files; it adds or changes no Ginkgo test code, so this test-quality check is inapplicable.
Microshift Test Compatibility	✅ Passed	The PR changes only feature-gate documentation, Go declarations, and YAML manifests; the diff adds no Ginkgo e2e tests or MicroShift-incompatible test references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The parent-to-HEAD diff changes only feature metadata and YAML manifests; it adds no Ginkgo e2e tests, so no SNO multi-node assumption is introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only promotes ImageModeStatusReporting in feature declarations and feature-gate lists; it adds no workloads or topology-sensitive scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR diff changes only feature-gate metadata and configuration; it adds no process-level code or stdout writes in main or suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request changes only feature-gate documentation, registration, and YAML manifests; it adds no Ginkgo e2e tests or network connectivity assumptions.
No-Weak-Crypto	✅ Passed	The diff only promotes ImageModeStatusReporting in feature metadata, Go gate configuration, and manifests; it adds no weak-crypto use, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The diff only promotes ImageModeStatusReporting; added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only changes feature-gate declarations, documentation, and manifest lists; it adds no logging statements or sensitive data fields.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[everettraven]

/testwith openshift/api/master/verify-feature-promotion #2782

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[yuqi-zhang]

/testwith openshift/api/master/verify-feature-promotion #2789

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[qodo-code-review]

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

[isabella-janssen]

/test verify-feature-promotion

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[isabella-janssen]

/test verify-feature-promotion

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	fff5a74	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.