OCPBUGS-65942: Add pod selector columns to Service, ReplicaSet, Job, and ReplicationController lists#16748
Conversation
… and ReplicationController lists
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@rzhabbarov: This pull request references Jira Issue OCPBUGS-65942, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rzhabbarov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @rzhabbarov. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughAdds a Services list page and registers it for Service resources. Jobs, ReplicaSets, and ReplicationControllers tables now display Pod selector columns with updated column mappings. ChangesService list and selector UI
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ServicesPage
participant ListPage
participant ServicesList
participant ConsoleDataView
ServicesPage->>ListPage: render Service list page
ListPage->>ServicesList: pass page props
ServicesList->>ConsoleDataView: provide service rows and columns
ConsoleDataView->>ServicesList: render selector and action cells
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

Analysis / Root cause:
Service, ReplicaSet, Job, and ReplicationController list views did not expose pod selector. This made these resources inconsistent with other workload list views such as Deployment, StatefulSet, DaemonSet, and DeploymentConfig, where users can see and click pod selectors directly from the table.
For Service specifically, the resource was using the generic default list page, so there was no Service-specific table definition where a Pod selector column could be added.
Solution description:
Added a Pod selector column to the ReplicaSet, Job, and ReplicationController list views.
Added a dedicated Kubernetes Service list page and registered it in the resource page mapping so Services can display resource-specific columns. The new Service list includes Name, Namespace, Labels, Pod selector, Created, and row actions.
The Pod selector cells reuse the existing
Selectorcomponent, which renders clickable selector links to the Pod search page with the appropriate namespace and label query.Screenshots / screen recording:

Test setup:
No special setup required.
Test cases:
/search/ns/<namespace>?kind=Pod&q=<selector>.No selector.Browser conformance:
Additional info:
Reviewers and assignees:
Summary by CodeRabbit