odh-dashboard: add required Prow lint, type-check, unit-tests - #83263
odh-dashboard: add required Prow lint, type-check, unit-tests#83263manaswinidas wants to merge 2 commits into
Conversation
Tide only retests Prow contexts before merge. Quality gates lived only in GitHub Actions, so green PRs could still race and break main (RHOAIENG-3333). Add a Node 22 test image (nodejs-22-src) while keeping the golang build_root for product image builds, and required always-run container tests for lint, type-check, and unit-tests. Quality jobs use skip_cloning so ci-operator gets a full checkout instead of the Dockerfile-only sparse checkout used by image jobs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@manaswinidas: GitHub didn't allow me to request PR reviews from the following users: opendatahub-io/dashboard-maintainers. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe CI configuration adds a Node.js 22 source container, resource requests, and jobs for dependency installation, linting, type-checking, and unit testing. ChangesODH Dashboard CI validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This PR adds required Prow lint, type-check, and unit-test gates without any identified current-head correctness or deployment risk; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @manaswinidas. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml`:
- Around line 42-49: Update the nodejs-22-src build definition by removing the
from: src override so it uses the Dockerfile’s Node.js 22 base image, and change
COPY --from=src . . to copy directly from the repository build context.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 56b8377b-5830-48f1-90ae-698c9bb4cffd
⛔ Files ignored due to path filters (1)
ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
|
/ok-to-test |
|
@manaswinidas: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test @christianvogt please take over here -- let me know if you need me. |
openshift-ci
Bot
added
ok-to-test
AI Review
|
Drop from: src so the test image keeps the Node 22 base and COPY the repo context. Match odh-dashboard GHA install (npm@11.8.0 + install:modules). Regenerate presubmits with make update instead of hand-editing skip_cloning. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@christianvogt Addressed your review in 0562536:
Please take another look when you can. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-lint pull-ci-opendatahub-io-odh-dashboard-main-type-check pull-ci-opendatahub-io-odh-dashboard-main-unit-tests |
|
@christianvogt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@manaswinidas: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
Addresses RHOAIENG-3333: Tide only retests Prow contexts against the latest base/merge SHA. odh-dashboard quality gates (lint / type-check / unit) currently run only in GitHub Actions, so two green PRs can still race and break
main(recent example: type-check break from mock import move vs new tests).Changes
build_rootand product image builds/mirrorsnodejs-22-src(UBI Node 22 + source viaCOPY --from=src) for quality tests; exclude it from promotionlint—npm ci+NODE_OPTIONS=--max-old-space-size=8192 npm run linttype-check—npm ci+npm run type-checkunit-tests—npm ci+npm run test-unitskip_cloning: trueso ci-operator gets a full checkout (image jobs keep Dockerfile sparse checkout)Phase 1 only. Cypress / contract tests stay on GitHub Actions for now (dual-run).
Test plan
/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-lintagainst an odh-dashboard PR/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-type-check/pj-rehearse pull-ci-opendatahub-io-odh-dashboard-main-unit-testsci/prow/lint,ci/prow/type-check,ci/prow/unit-testsare required (nooptional: true)/cc @opendatahub-io/dashboard-maintainers
Made with Cursor
Summary by CodeRabbit
Updates the
odh-dashboardOpenShift CI configuration to add Prow quality gates. The configuration now:nodejs-22-srctest image.lint,type-check, andunit-testscontainer tests.