Skip to content

[DNM] Check s2i switch - #1208

Open
karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check
Open

karelyatin wants to merge 1 commit into
openstack-k8s-operators:mainfrom
karelyatin:s2i_check

Conversation

@karelyatin

@karelyatin karelyatin commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karelyatin
Once this PR has been reviewed and has the lgtm label, please assign seanmooney for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: eb8d0809-e6ed-436d-88f7-cdfe67677c90

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd6ced and 4c18de9.

📒 Files selected for processing (2)
  • .zuul.yaml
  • templates/cyborg/00-default.conf

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Marked the workflow and Cyborg configuration template as “do not merge” for review.
    • Standardized shared Tempest image settings across the standard, Ceph, and Cyborg test jobs.

Walkthrough

The change adds # DNM markers to the Zuul workflow and Cyborg template. It also defines shared Tempest image settings for the standard job and reuses them in the Ceph and Cyborg jobs.

Changes

Zuul workflow and template configuration

Layer / File(s) Summary
Add do-not-merge markers
.zuul.yaml, templates/cyborg/00-default.conf
Adds a # DNM comment at the start of both configuration files.
Share Tempest image settings
.zuul.yaml
Defines the Tempest image and master-latest tag for the standard job. The Ceph and Cyborg jobs reuse these settings.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: amoralej

Merge Risk: ⚪ Minimal · up to 4c18d

No concrete merge-blocking risk is established by this change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the pull request as a DNM check for the s2i switch, which matches the stated objective and dependencies.
Description check ✅ Passed The description lists dependencies that are directly related to the stated s2i switch check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/6204b21456dd44e7928db0a04feff956

✔️ openstack-meta-content-provider SUCCESS in 2h 55m 12s
✔️ nova-operator-kuttl SUCCESS in 1h 01m 10s
✔️ nova-operator-kuttl-placement SUCCESS in 41m 13s
nova-operator-tempest-multinode FAILURE in 2h 32m 09s
nova-operator-tempest-multinode-ceph FAILURE in 2h 37m 31s

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#2070 is needed.

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#4190 is needed.

@karelyatin

Copy link
Copy Markdown
Contributor Author

recheck depends-on

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#4190 is needed.

@karelyatin

Copy link
Copy Markdown
Contributor Author

recheck depends-on

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/0a766073f262472488995ba3273619d4

✔️ openstack-meta-content-provider SUCCESS in 3h 09m 29s
✔️ nova-operator-kuttl SUCCESS in 51m 43s
✔️ nova-operator-kuttl-placement SUCCESS in 37m 58s
nova-operator-tempest-multinode FAILURE in 2h 22m 43s
nova-operator-tempest-multinode-ceph FAILURE in 2h 27m 42s
✔️ nova-operator-cyborg-tempest-multinode SUCCESS in 1h 39m 01s (non-voting)

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4b6927405fa34662962ea1b2e2149746

✔️ openstack-meta-content-provider SUCCESS in 8h 26m 44s
✔️ nova-operator-kuttl SUCCESS in 51m 52s
✔️ nova-operator-kuttl-placement SUCCESS in 40m 17s
nova-operator-tempest-multinode FAILURE in 2h 10m 30s
nova-operator-tempest-multinode-ceph FAILURE in 2h 44m 08s
✔️ nova-operator-cyborg-tempest-multinode SUCCESS in 1h 44m 34s (non-voting)

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/28d6a960a503438e83ab58b0235eba51

✔️ openstack-meta-content-provider SUCCESS in 4h 14m 30s
✔️ nova-operator-kuttl SUCCESS in 51m 30s
✔️ nova-operator-kuttl-placement SUCCESS in 40m 50s
nova-operator-tempest-multinode FAILURE in 2h 17m 25s
nova-operator-tempest-multinode-ceph FAILURE in 2h 40m 49s
nova-operator-cyborg-tempest-multinode FAILURE in 31m 14s (non-voting)

@Dyrkon

Dyrkon commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

recheck depends-on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants