Skip to content

chore: conform to the documented conventions - #486

Merged
retr0h merged 32 commits into
mainfrom
chore/conform-to-contributing
Sep 12, 2026
Merged

retr0h merged 32 commits into
mainfrom
chore/conform-to-contributing

test: give the row callbacks the type the call returns

a2d4241
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2026 in 0s

99.94% (target 99.90%)

View this Pull Request on Codecov

99.94% (target 99.90%)

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   99.94%   99.94%   -0.01%     
==========================================
  Files         484      484              
  Lines       22877    22876       -1     
==========================================
- Hits        22865    22864       -1     
  Misses         12       12              
Files with missing lines Coverage Δ
internal/controller/api/file/file_stale.go 100.00% <ø> (ø)
internal/controller/api/job/job_get.go 100.00% <100.00%> (ø)
internal/facts/keys.go 100.00% <ø> (ø)
internal/provider/container/docker/docker.go 100.00% <ø> (ø)
internal/provider/network/netplan/dns/darwin.go 100.00% <ø> (ø)
...netplan/dns/darwin_get_by_interface_resolv_conf.go 100.00% <ø> (ø)
...plan/dns/darwin_update_resolv_conf_by_interface.go 100.00% <ø> (ø)
internal/provider/network/ping/darwin.go 100.00% <ø> (ø)
internal/provider/network/ping/darwin_do.go 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7e623...a2d4241. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.