Repository navigation
Fix/gobgp legacy withdraw - #631
Open
nuclearcat wants to merge 2 commits into
Open
nuclearcat wants to merge 2 commits into
nuclearcat wants to merge 2 commits into
Conversation
Accept the public GoBGP v4 binary NLRI and attribute fields while preserving structured requests. Validate binary input before installing routes. Assisted-by: OpenAI Codex Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Support withdrawal by NLRI through AddPath and invalidate removed UUID handles. Retain UUID-based DeletePath and isolate unrelated paths. Assisted-by: OpenAI Codex Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support of GoBGP binary NLRI and attribute fields and supports withdrawals through both legacy
AddPathwithis_withdraw = trueand UUID-freeDeletePath. GoBGP CLIrib delnow works for IPv4, IPv6, FlowSpec, path identifiers, and VRF paths.global rib del allwithdraws locally injected routes in the selected address family while preserving peer and kernel routes.Withdrawals identify a local path by NLRI and path identifier. Withdrawing an absent path succeeds silently, matching GoBGP. Removed UUID handles are invalidated so they cannot delete a later announcement. UUID-based
DeletePathremains supported and takes precedence over path and bulk selectors. VRF path deletions are translated to the VRF's exported VPN NLRI; bulk VRF deletions are scoped by RD and export label.The real GoBGP v4.8.0 CLI passed the new CLI-only end-to-end test, including repeated withdrawals, multiple path identifiers, family-scoped bulk deletion, FlowSpec, and VRF isolation.
For example, after
gobgp global rib add 198.51.100.42/32, withdraw it withgobgp global rib del 198.51.100.42/32. No UUID state is needed. Usegobgp global rib del all -a ipv4to remove all local IPv4 paths. Programmatic clients can callDeletePathwith aPathcontaining the same family, NLRI, and identifier used for the announcement.Fixes: #616.
Did you use an AI tool?
Assisted-by: Codex AI