Skip to content

AO3-7505 Fixing the error messages for blank collection names and titles and i18n-ing collection.rb - #5947

Open
ASalbenblatt wants to merge 6 commits into
otwcode:masterfrom
ASalbenblatt:AO3-7505-Error-messages-for-blank-collection-name-or-title-are-malformed
Open

AO3-7505 Fixing the error messages for blank collection names and titles and i18n-ing collection.rb#5947
ASalbenblatt wants to merge 6 commits into
otwcode:masterfrom
ASalbenblatt:AO3-7505-Error-messages-for-blank-collection-name-or-title-are-malformed

Conversation

@ASalbenblatt

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7505

Purpose

The errors for blank collection titles and names used to say:

  • Name Please enter a name for your collection.
  • Title Please enter a title to be displayed for your collection.
    This fix corrects them so they say:
  • Please enter a name for your collection.
  • Please enter a title to be displayed for your collection.

I also i18n-ed the file I was working in which was app/models/collection.rb

Testing Instructions

In addition to the testing listed in Jira, all text should be in t() functions, and it should all display properly and identically to how it did before throughout the collection creation screen.

Credit

FlyingFalcon they/them

@github-actions github-actions Bot added the Has Migrations Contains migrations and therefore needs special attention when deploying label Jul 28, 2026
@ASalbenblatt

Copy link
Copy Markdown
Contributor Author

I know it looks like rubocop is still failing, but that's just because the migration hasn't been schema dumped, and rubocop only looks at the schema file (docs on this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Review Has Migrations Contains migrations and therefore needs special attention when deploying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant