AO3-7505 Fixing the error messages for blank collection names and titles and i18n-ing collection.rb - #5947
Open
ASalbenblatt wants to merge 6 commits into
Conversation
…king a collection without entering anything
… they shouldn't be prepended to
…on-name-or-title-are-malformed
Contributor
Author
|
I know it looks like rubocop is still failing, but that's just because the migration hasn't been schema dumped, and rubocop only looks at the schema file (docs on this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7505
Purpose
The errors for blank collection titles and names used to say:
This fix corrects them so they say:
I also i18n-ed the file I was working in which was app/models/collection.rb
Testing Instructions
In addition to the testing listed in Jira, all text should be in t() functions, and it should all display properly and identically to how it did before throughout the collection creation screen.
Credit
FlyingFalcon they/them