bgp: Add composable wrappers for {get,set}sockopt - #900
Open
taspelund wants to merge 1 commit into
Conversation
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
taspelund
force-pushed
the
jj-stack/bgp-add-composable-wrappers-for-get-set-sockopt-xqyysnkr
branch
from
September 2, 2026 19:20
543da50 to
9d83e29
Compare
taspelund
force-pushed
the
jj-stack/bgp-add-composable-wrappers-for-get-set-sockopt-xqyysnkr
branch
2 times, most recently
from
September 2, 2026 20:40
0bf3422 to
109cc76
Compare
taspelund
requested review from
cfzimmerman,
internet-diglett,
nicolaskagami,
rcgoodfellow and
zeeshanlakhani
September 2, 2026 20:43
taspelund
added
bgp
taspelund
force-pushed
the
jj-stack/bgp-add-composable-wrappers-for-get-set-sockopt-xqyysnkr
branch
from
September 3, 2026 21:18
109cc76 to
d1ff6f0
Compare
Instead of jamming unsafe calls to libc::{get,set}sockopt, centralize it
to just one wrapper for each method and use option-specific wrappers.
Also fix incorrect sockopt name for IPv6 TTL:
IP_MINTTL -> IPV6_MINHOPCOUNT
Fixes: #647
Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund
force-pushed
the
jj-stack/bgp-add-composable-wrappers-for-get-set-sockopt-xqyysnkr
branch
from
September 4, 2026 21:27
d1ff6f0 to
1abfb30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of jamming unsafe calls to libc::{get,set}sockopt, centralize it to just one wrapper for each method and use option-specific wrappers.
Also fix incorrect sockopt name for IPv6 TTL: IP_MINTTL -> IPV6_MINHOPCOUNT
Fixes: #647
Signed-off-by: Trey Aspelund trey@oxidecomputer.com