falcon-lab: interact with nodes concurrently - #901
Open
taspelund wants to merge 1 commit into
Open
Conversation
taspelund
requested review from
cfzimmerman,
internet-diglett,
nicolaskagami,
rcgoodfellow and
zeeshanlakhani
September 1, 2026 00:09
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
taspelund
force-pushed
the
jj-stack/falcon-lab-interact-with-nodes-concurrently-zvuyompz
branch
from
September 2, 2026 19:20
f88b817 to
07a8a19
Compare
Base automatically changed from
jj-stack/falcon-lab-separate-topologies-from-scenarios-osrxywxx
to
main
September 3, 2026 21:18
taspelund
force-pushed
the
jj-stack/falcon-lab-interact-with-nodes-concurrently-zvuyompz
branch
from
September 3, 2026 21:18
07a8a19 to
23f32ec
Compare
Start interacting with falcon nodes concurrently, when possible. In some circumstances, test execution takes quite a long time because checks across multiple nodes are done serially even when doing so isn't needed for the semantics of the test. The biggest example of this is in the BFD test, where each state transition must pass 5 consecutive checks. Before, the BFD test took almost 10 minutes to complete: ``` Aug 30 01:16:47.008 INFO phase 1: all peers up [..] Aug 30 01:26:13.247 INFO interop bfd static routing test passed ``` After, the BFD test takes <3 minutes to complete: ``` Aug 30 20:11:40.563 INFO phase 1: all peers up [..] Aug 30 20:14:06.527 INFO interop bfd static routing test passed ``` Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund
force-pushed
the
jj-stack/falcon-lab-interact-with-nodes-concurrently-zvuyompz
branch
from
September 4, 2026 21:27
23f32ec to
ee08219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start interacting with falcon nodes concurrently, when possible. In some circumstances, test execution takes quite a long time because checks across multiple nodes are done serially even when doing so isn't needed for the semantics of the test. The biggest example of this is in the BFD test, where each state transition must pass 5 consecutive checks.
Before, the BFD test took almost 10 minutes to complete:
After, the BFD test takes <3 minutes to complete:
Signed-off-by: Trey Aspelund trey@oxidecomputer.com