Remove old sled agent api versions - #11205
Conversation
| #[path = "typed_sled_config_generation/mod.rs"] | ||
| pub mod v50; | ||
| #[path = "retire_up_to_version_23/mod.rs"] | ||
| pub mod v51; |
There was a problem hiding this comment.
We chatted about this offline - I think we don't want to add a new types module here (because we're not adding / changing any types) - anything that's in this module as written should be left wherever it was originally, which should mean we leave latest.rs untouched.
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
This all looks reasonable to me! I'd love to get a glance from @sunshowers, time permitting, particularly to make sure we made the right call on #11205 (comment). The only other option that seems reasonable to me now is "just leave all the stale types around", but that's mostly because it seems so painful to do the work to prune them all.
| path = "/network-bootstore-config", | ||
| versions = VERSION_BGP_V6..VERSION_REMOVE_READ_BOOTSTORE_CONFIG_CACHE, | ||
| }] | ||
| async fn read_network_bootstore_config_cache( |
There was a problem hiding this comment.
@andrewjstone will be very, very happy to see this gone
One thing that clicked for me when we were chatting in our DMs - if we follow the "just leave the stale types around" idea, and imagine retiring all the sled-agent API versions up to the latest, then the only types that remain will be the ones directly referenced in But I think I may be misunderstanding the quoted comment - is there stuff I missed pruning? |
I think that's true but in practice it'll be rare we can return all but the latest (we'd have to go a full release cycle with no changes for that to be safe).
Not that I noticed! I was mostly commenting on the level of effort to do the pruning at all. |
2 participants
Retire up to sled-agent version 23 - this removes several problematic API versions present in old versions and cleans up the associated code.
sled-agent-type-versionstypes that are no longer used have also been removed, as many as a tool I wrote could be found.