[6/n] [reconfigurator] refactor rendezvous_sled_bp_availability writes - #11209
Merged
sunshowers merged 5 commits intoSep 4, 2026
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
reviewed
Sep 3, 2026
Created using spr 1.3.6-beta.1
Contributor
Author
|
Made the following changes:
|
jgallagher
approved these changes
Sep 4, 2026
|
|
||
| impl SledBpAvailabilityWrite { | ||
| /// Log this write to the given logger, and increment the corresponding | ||
| /// scount in `stats`. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// scount in `stats`. | |
| /// count in `stats`. |
Contributor
Author
There was a problem hiding this comment.
Thanks. I'd fixed it locally but forgot to amend my local commit. (But also a typo is pretty good evidence that I didn't have Claude write it ;) )
| let rejected_upsert = sled(3); | ||
| let rejected_decommission = sled(13); | ||
|
|
||
| // Inject a deterministic failure via a test-only CHECK constraint. |
Contributor
There was a problem hiding this comment.
Ooh this is a cool technique 👍
Contributor
Author
There was a problem hiding this comment.
Wish I could claim credit for it, but all I did was push Fable to find a way lol
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
September 4, 2026 17:06
sunshowers
deleted the
sunshowers/spr/6n-reconfigurator-refactor-rendezvous_sled_bp_availability-writes
branch
September 4, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I just introduced this very recently, but I realized that we have other use cases that would benefit from a bulk write API.
This doesn't have any functional changes -- it only converts the way the datastore layer works from lots of little calls to one single bulk call.