Update git dependencies and pin revisions - #11223
Open
jmpesp wants to merge 2 commits into
Open
Conversation
Change one of the dice-util dependencies so that it refers to a specific pinned revision (copying the one in Cargo.lock) instead of a branch. before: ``` $ cargo tree -i dice-verifier error: specification `dice-verifier` is ambiguous help: re-run this command with one of the following specifications git+https://github.com/oxidecomputer/dice-util?branch=main#dice-verifier@0.3.0-pre0 git+https://github.com/oxidecomputer/dice-util?rev=4a39ef08d81e5177edee0bddb1146032aa21074d#dice-verifier@0.3.0-pre0 ``` after: ``` $ cargo tree -i dice-verifier error: specification `dice-verifier` is ambiguous help: re-run this command with one of the following specifications git+https://github.com/oxidecomputer/dice-util?rev=4a39ef08d81e5177edee0bddb1146032aa21074d#dice-verifier@0.3.0-pre0 git+https://github.com/oxidecomputer/dice-util?rev=ff9f27aa0d6ef6fb64c349890b6e3c242ea3d8fc#dice-verifier@0.3.0-pre0 ``` Update management-gateway-service to the latest rev to pull in the latest hubtools. Also update package-manifest.toml rev and sha256 accordingly. This pulled in some new `SpHandler trait functions that needed implementing, so fill those in. Also update to the latest hubtools.
Contributor
Author
|
@jordanhendricks @flihp @papertigers I would also appreciate eyes on this from someone familiar with these deps, I don't believe I have regressed anything here. |
jgallagher
reviewed
Sep 3, 2026
jgallagher
left a comment
jgallagher
left a comment
Contributor
There was a problem hiding this comment.
MGS-related changes LGTM (modulo two questions below).
| futures-sink = { version = "0.3.32" } | ||
| futures-task = { version = "0.3.32", default-features = false, features = ["std"] } | ||
| futures-util = { version = "0.3.32", features = ["channel", "io", "sink"] } | ||
| gateway-ereport-messages = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "6c0aca2545a73fd75536e149d29faa7108be5862", default-features = false, features = ["debug-impls", "serde"] } |
Contributor
There was a problem hiding this comment.
Any idea why we lost gateway-ereport-messages in this file?
| only_for_targets.image = "standard" | ||
| source.type = "composite" | ||
| source.packages = [ | ||
| "omicron-faux-mgs.tar.gz", |
Contributor
There was a problem hiding this comment.
Is this useful in the stub package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change one of the dice-util dependencies so that it refers to a specific pinned revision (copying the one in Cargo.lock) instead of a branch.
before:
after:
Update management-gateway-service to the latest rev to pull in the latest hubtools. Also update package-manifest.toml rev and sha256 accordingly. This pulled in some new `SpHandler trait functions that needed implementing, so fill those in.
Also update to the latest hubtools.