Repository navigation
fix(server): cancel pending ws calls when the connection closes - #1656
Merged
bkchr merged 4 commits intoSep 30, 2026
Merged
Conversation
WebSocket calls run on detached tasks, so a closed connection left them running to completion with nobody to send the response to.
bkchr
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every WebSocket call runs on its own spawned task that is not tied to the connection. When the connection closes, these tasks keep running until the method returns, and the response is then discarded. For expensive methods this means a client that disconnects or times out leaves the work running on the server with no way to cancel it, unlike HTTP where hyper drops the service future when the client goes away.
The call is now raced against
MethodSink::closed, which resolves once the connection's send task exits, so the method future is dropped when the connection is gone. Graceful shutdown still drains pending calls because the send task keeps running until they are done, and subscriptions are unaffected since their tasks are spawned separately.