Skip to content

build!: require php-forge/debug ^0.3. - #17

Merged
terabytesoftw merged 1 commit into
mainfrom
build/update-dependencies
Sep 17, 2026
Merged

terabytesoftw merged 1 commit into
mainfrom
build/update-dependencies

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

@terabytesoftw terabytesoftw added the enhancement New feature or request label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5eabe6f1-f0f7-4cb4-b275-d7e2f80b0487

📥 Commits

Reviewing files that changed from the base of the PR and between 46e0441 and cc5b561.

📒 Files selected for processing (12)
  • CHANGELOG.md
  • composer.json
  • src/Debug/InertiaPanel.php
  • tests/Debug/InertiaCollectorTest.php
  • tests/Debug/InertiaPanelTest.php
  • tests/Debug/fixtures/conflict-no-target.view.json
  • tests/Debug/fixtures/conflict.view.json
  • tests/Debug/fixtures/empty.view.json
  • tests/Debug/fixtures/full-partial-header.view.json
  • tests/Debug/fixtures/no-props.view.json
  • tests/Debug/fixtures/page.view.json
  • tests/Debug/fixtures/partial.view.json
💤 Files with no reviewable changes (1)
  • tests/Debug/InertiaCollectorTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
🧰 Additional context used
🪛 PHPMD (2.15.0)
src/Debug/InertiaPanel.php

[warning] 52-160: The method present() has a Cyclomatic Complexity of 26. The configured cyclomatic complexity threshold is 10. (undefined)

(CyclomaticComplexity)


[warning] 52-160: The method present() has an NPath complexity of 921600. The configured NPath complexity threshold is 200. (undefined)

(NPathComplexity)


[warning] 52-160: The method present() has 109 lines of code. Current threshold is set to 100. Avoid really long methods. (undefined)

(ExcessiveMethodLength)

tests/Debug/InertiaPanelTest.php

[error] 34-487: The class InertiaPanelTest has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13. (undefined)

(CouplingBetweenObjects)

🔇 Additional comments (11)
composer.json (1)

23-23: LGTM!

CHANGELOG.md (1)

8-10: LGTM!

src/Debug/InertiaPanel.php (1)

92-92: LGTM!

tests/Debug/InertiaPanelTest.php (1)

252-252: LGTM!

tests/Debug/fixtures/conflict-no-target.view.json (1)

75-75: LGTM!

tests/Debug/fixtures/partial.view.json (1)

150-150: LGTM!

tests/Debug/fixtures/conflict.view.json (1)

75-75: LGTM!

tests/Debug/fixtures/empty.view.json (1)

60-60: LGTM!

tests/Debug/fixtures/full-partial-header.view.json (1)

181-181: LGTM!

tests/Debug/fixtures/no-props.view.json (1)

97-97: LGTM!

tests/Debug/fixtures/page.view.json (1)

181-181: LGTM!


📝 Summary

Summary by CodeRabbit

  • Breaking Changes

    • Updated the minimum required php-forge/debug runtime dependency from ^0.2 to ^0.3.
    • Inertia panel views no longer expose an active state based on captured pages or request headers.
  • Documentation

    • Updated the unreleased changelog version to 0.5.0 and documented the new build requirement.
  • Tests

    • Updated expected view output to reflect the removal of the active property.

Walkthrough

The PR raises the php-forge/debug requirement to ^0.3, updates the unreleased version to 0.5.0, and removes active-state output from Inertia panel views and their test expectations.

Changes

Inertia panel update

Layer / File(s) Summary
Dependency and release metadata
composer.json, CHANGELOG.md
The php-forge/debug constraint changes from ^0.2 to ^0.3. The changelog version changes to 0.5.0 and records the breaking build requirement.
Panel activity output and expectations
src/Debug/InertiaPanel.php, tests/Debug/InertiaCollectorTest.php, tests/Debug/InertiaPanelTest.php, tests/Debug/fixtures/*
InertiaPanel::present() no longer sets the panel active. Tests and view fixtures no longer include or assert the active property.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to cc5b5

The PR removes an unsupported panel field and remains compatible with php-forge/debug:^0.3; no concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (9 skipped: 9… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: requiring php-forge/debug ^0.3. The breaking-change marker is appropriate.
Description check ✅ Passed The description identifies this as a breaking change, which matches the dependency requirement update and related behavior changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. (9 skipped: 9 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checked the panel view
The active flag was gone from view
The debug version hopped ahead
The fixtures matched what code said
The changelog marked the trail anew

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.74%. Comparing base (0bec59e) to head (cc5b561).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #17      +/-   ##
============================================
- Coverage     99.74%   99.74%   -0.01%     
+ Complexity      493      492       -1     
============================================
  Files            33       33              
  Lines          1172     1171       -1     
============================================
- Hits           1169     1168       -1     
  Misses            3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@terabytesoftw
terabytesoftw merged commit abfa417 into main Sep 17, 2026
43 checks passed
@terabytesoftw
terabytesoftw deleted the build/update-dependencies branch September 17, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant