chore: update the entire app to use typescript 7 - #1114
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
2375e61 to
61ddd3d
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
894cd84 to
19a1eb1
Compare
This involved updating a bunch of deps and cleaning up a bunch of typescript configuration
Making something smol n reviewable for Alex
- `apps/docs/app/(trees)/_components/DemoContextMenuClient.tsx`
- Replace effect-managed portal state with a stable
`useSyncExternalStore` snapshot of the root portal container.
- `apps/docs/app/(trees)/_components/DemoDragDropClient.tsx`
- Reset drag status directly when toggling the locked model instead of
synchronously from the model-reset effect.
- `apps/docs/app/(trees)/_components/DemoThemingClient.tsx`
- Subscribe to the system color scheme with `useSyncExternalStore`.
- Move theme loading state changes into asynchronous resolution
callbacks and associate errors with the requested theme.
- Remove the unnecessary initial-theme loading indicator.
- `apps/docs/app/(trees)/_components/DemoTreeAppClient.tsx`
- Add resettable local state that reconciles file and prerendered HTML
maps before commit when server inputs change.
- Read the stable portal container through `useSyncExternalStore`.
- Include the resettable setters in the mutation subscription
dependencies.
- `apps/docs/app/(trees)/_components/TreeApp.tsx`
- Isolate intentional render-time ref reads and writes behind
dedicated hook boundaries.
- Collapse desktop tabs during the render that switches to the mobile
layout instead of from an effect.
- `apps/docs/app/(trees)/trees-dev/_components/TreesDevShell.tsx`
- Associate the open mobile menu with the current navigation identity
so route changes close it without an effect-driven state update.
- `apps/docs/app/(trees)/trees-dev/_demos/ItemCustomizationDemoClient.tsx`
- Isolate the intentional render-time selected-path ref read behind a
hook boundary.
- `apps/docs/app/(trees)/trees-dev/_demos/MainDemoClient.tsx`
- Reconcile the optimistic workload selection during render when the
authoritative workload changes, removing the effect-driven state
reset.
- `apps/docs/app/(trees)/trees-dev/_demos/ResponsivenessDemoClient.tsx`
- Isolate the intentional render-time container measurement behind a
hook boundary.
- `packages/trees/src/render/FileTreeView.tsx`
- Disable the React ref rule for the Preact renderer, whose ref
behavior is not governed by React Compiler rules.
- `packages/trees/test/file-tree-react.test.tsx`
- Add targeted suppressions for intentional model capture in test
harnesses.
- Expand context-menu composition coverage to verify preservation,
removal, stale-state invalidation, and reopening behavior.
Because it'll fuck with git stuff, and it's generally good to have these checked in, imo...
19a1eb1 to
d1445ed
Compare
1 participant
Summary
tsgodependency with the TypeScript 7tscCLI.Details
tscimplementation.