Skip to content

v8.5.7: clarify DM foreign key support for one-to-one routing (#23153) - #23183

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:feature/preview-v8.5.7from
ti-chi-bot:cherry-pick-23153-to-release-8.5
Jul 1, 2026
Merged

ti-chi-bot[bot] merged 4 commits into
pingcap:feature/preview-v8.5.7from
ti-chi-bot:cherry-pick-23153-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23153

What is changed, added or deleted? (Required)

  • Clarify DM foreign key replication constraints when foreign_key_checks=1.
  • Document that DM supports static one-to-one table routing for multi-worker foreign key causality, and still rejects route rules that map multiple source tables in the task to the same target table in this mode.
  • Document that compact and multiple-rows are not supported when foreign_key_checks=1.
  • Document hot configuration update restrictions when foreign_key_checks=1 and worker-count > 1.
  • Add a schema correctness note recommending standard foreign key definitions before migration.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

OliverS929 and others added 4 commits July 1, 2026 06:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Airton Lastori <alastori@gmail.com>
@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DM documentation to detail the experimental support and limitations for replicating tables with foreign key constraints, including new static one-to-one table routing capabilities introduced in version 8.5.7. The review feedback correctly identifies style guide violations where the version is referred to as v8.5.7 instead of DM v8.5.7, and provides actionable suggestions to align with the repository's versioning notation rules.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dm/dm-compatibility-catalog.md
Comment thread dm/dm-compatibility-catalog.md
Comment thread dm/dm-safe-mode.md
@lilin90 lilin90 self-assigned this Jul 1, 2026
@lilin90 lilin90 changed the title master: clarify DM foreign key support for one-to-one routing (#23153) v8.5.7: clarify DM foreign key support for one-to-one routing (#23153) Jul 1, 2026
@lilin90
lilin90 changed the base branch from release-8.5 to feature/preview-v8.5.7 July 1, 2026 06:46
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2026
@lilin90
lilin90 changed the base branch from feature/preview-v8.5.7 to release-8.5 July 1, 2026 06:47
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2026
@lilin90
lilin90 changed the base branch from release-8.5 to feature/preview-v8.5.7 July 1, 2026 07:06
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2026
@lilin90
lilin90 changed the base branch from feature/preview-v8.5.7 to release-8.5 July 1, 2026 07:07
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2026
@lilin90
lilin90 changed the base branch from release-8.5 to feature/preview-v8.5.7 July 1, 2026 07:08

@lilin90 lilin90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 1, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 3db150c into pingcap:feature/preview-v8.5.7 Jul 1, 2026
11 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-23153-to-release-8.5 branch July 1, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants