Skip to content

DM: Improve MariaDB permission handling - #12404

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:mariadb
Mar 30, 2026
Merged

ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
dveeden:mariadb

Conversation

@dveeden

@dveeden dveeden commented Nov 20, 2025 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #12207

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

The privilege checker was improved to better handle MariaDB specific privileges

Hold

Once the pingcap/tidb PR that this depends on has been merged this commit should be updated to:

  • Use the commit from that PR for the parser (or newer)
  • Remove the replace lines in go.mod for pingcap/tidb and the parser.

@ti-chi-bot

ti-chi-bot Bot commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dm Issues or PRs related to DM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2025
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2025
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Nov 23, 2025
@dveeden dveeden changed the title WIP: MariaDB DM: Improve MariaDB permission handling Nov 23, 2025
@dveeden

dveeden commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

/type feature

@ti-chi-bot ti-chi-bot Bot added the type/feature Issues about a new feature label Nov 23, 2025
@dveeden

dveeden commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

/unlabel type/feature

@dveeden
dveeden marked this pull request as ready for review November 23, 2025 14:11
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2025
@dveeden

dveeden commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2025
@dveeden

dveeden commented Nov 23, 2025

Copy link
Copy Markdown
Contributor Author

/cc @lance6716 @D3Hunter

@ti-chi-bot
ti-chi-bot Bot requested review from D3Hunter and lance6716 November 23, 2025 14:24
@dveeden dveeden mentioned this pull request Nov 25, 2025
5 of 18 tasks
@dveeden

dveeden commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

/cc @OliverS929

@ti-chi-bot
ti-chi-bot Bot requested a review from OliverS929 November 29, 2025 09:44
Comment thread go.mod Resolved
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 23, 2026
@dveeden

dveeden commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2026
@dveeden

dveeden commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@dveeden

dveeden commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2026
@codecov

codecov Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@abbaf8d). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 57.3233% <ø> (?)
dm 49.1454% <45.4545%> (?)
engine 50.7223% <ø> (?)
Flag Coverage Δ
cdc 57.3233% <ø> (?)
unit 53.3888% <45.4545%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@             Coverage Diff             @@
##             master     #12404   +/-   ##
===========================================
  Coverage          ?   53.3888%           
===========================================
  Files             ?       1011           
  Lines             ?     139913           
  Branches          ?          0           
===========================================
  Hits              ?      74698           
  Misses            ?      59605           
  Partials          ?       5610           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dveeden

dveeden commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@dveeden

dveeden commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@dveeden

dveeden commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@lance6716 lance6716 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does our CI have a newer MariaDB to test this PR?

/cc @GMHDBJD

@ti-chi-bot
ti-chi-bot Bot requested a review from GMHDBJD March 26, 2026 07:05
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 26, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-03-26 07:05:39.279061288 +0000 UTC m=+424735.315131558: ☑️ agreed by lance6716.
  • 2026-03-30 07:20:26.866660786 +0000 UTC m=+163232.072020833: ☑️ agreed by D3Hunter.

@dveeden

dveeden commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot
ti-chi-bot Bot merged commit 267a950 into pingcap:master Mar 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/dm Issues or PRs related to DM. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/feature Issues about a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DM fails when checking privileges due to unsupported syntax on MariaDB

3 participants