Repository navigation
Conversation
|
/cc @OliverS929 |
There was a problem hiding this comment.
Code Review
This pull request updates several Go dependencies in go.mod and go.sum, including grpc-gateway, x/net, x/sys, x/text, and grpc. A critical issue was identified where the upgrade of golang.org/x/text to v0.37.0 is rendered ineffective by a replace directive that forces the version to v0.28.0, which may prevent the application of intended security fixes.
|
/retest |
1 similar comment
|
/retest |
|
@dveeden: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #12637
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note