Repository navigation
dm: support FK causality for one-to-one routes (#12675) - #12707
ti-chi-bot[bot] merged 3 commits into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@OliverS929 This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for foreign key (FK) causality in one-to-one routing scenarios within DM. It adds task-level route topology validation, case-insensitive table identity matching, and causality key generation adjustments. However, the pull request contains several critical issues that must be addressed: multiple unresolved git conflict markers are present across several configuration, test, and error definition files. Additionally, there are several potential nil pointer dereference panics in sameForeignKeyTableIdentity, causalityKeySourceTableNameForRowChange, and foreignKeyRouteTopologyTableID that require defensive nil checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #12707 +/- ##
================================================
Coverage ? 53.5566%
================================================
Files ? 1026
Lines ? 138108
Branches ? 0
================================================
Hits ? 73966
Misses ? 58612
Partials ? 5530 🚀 New features to boost your workflow:
|
|
/retest |
|
/unhold |
|
@OliverS929: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, OliverS929, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-cla |
This is an automated cherry-pick of #12675
What problem does this PR solve?
Issue Number: ref #12350
What is changed and how it works?
Support DM FK causality when
foreign_key_checks=1andsyncer.worker-count > 1with static one-to-one route rules.This PR:
foreign_key_checks=1A follow-up PR will explicitly reject hot updates that can change route/filter/case-sensitive/FK causality mode.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note