Repository navigation
Updating Android Small WebRTC sample to v1.1.0 - #106
Merged
Merged
Conversation
Contributor
Author
|
CI expected to fail until new transport is released. |
markbackman
approved these changes
Oct 28, 2025
filipi87
reviewed
Oct 29, 2025
filipi87
left a comment
filipi87
left a comment
Contributor
There was a problem hiding this comment.
On iOS, I’ve also allowed the user to specify the authorizationToken, so I could test the demo directly with Pipecat Cloud. It might be nice to support that here as well.
marcus-daily
force-pushed
the
marcus/small_webrtc_v1.1.0
branch
from
December 16, 2025 12:49
981bab5 to
56ccde0
Compare
mattieruth
reviewed
Dec 16, 2025
| override fun onBotOutput(data: MsgServerToClient.Data.BotOutputData) { | ||
| Log.i(TAG, "Bot output: $data") | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
i can't comment on unchanged lines... but i'd remove the onBotTranscript handler.
Contributor
Author
There was a problem hiding this comment.
Makes sense, will do.
mattieruth
approved these changes
Dec 16, 2025
mattieruth
left a comment
mattieruth
left a comment
Contributor
There was a problem hiding this comment.
i think just the one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.