Repository navigation
Dependency updates, fixes for connection issue and bot transcript issue - #234
Merged
Merged
Conversation
mattieruth
approved these changes
Jul 15, 2026
mattieruth
left a comment
mattieruth
left a comment
Contributor
There was a problem hiding this comment.
seems ok to me, minus the failing test
filipi87
reviewed
Jul 15, 2026
| // for a WebRTC offer. Self-hosted runners ignore unknown fields. | ||
| requestData = when (transportType) { | ||
| TransportType.Daily -> Value.Object( | ||
| "createDailyRoom" to Value.Bool(true), |
Contributor
There was a problem hiding this comment.
We should also add this here:
"transport" to Value.Str("daily"),
Contributor
Author
There was a problem hiding this comment.
Thanks, makes sense. I'll update this.
filipi87
approved these changes
Jul 15, 2026
filipi87
left a comment
filipi87
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just one comment, that we need to add the missing transport for Daily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.