Repository navigation
List shadcn/ui in the client's third-party notices - #62
Merged
Merged
Conversation
The shadcn/ui components are copied into client/src/components/ui and the shadcn stylesheet is pulled in through a CSS @import, so neither appears among the bundled npm packages the notices generator reads. The generator now takes packages to include explicitly and vendored code with its license text, and the client lists both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client build writes
THIRD_PARTY_NOTICES.txtintoclient/distby listing the npm packages whose code ends up in the bundle. shadcn/ui reaches the bundle two other ways, so its MIT license was missing from the notices: its components are copied intoclient/src/components/ui, and theshadcnstylesheet comes in through a CSS@import, which the generator doesn't see as a module.thirdPartyNotices()now takes two options.packagesnames npm packages to include even when nothing imports them as modules.vendoredlists code copied into the repo, each with a name, license, source link and license-text file. Vendored entries have no version, so they're listed by name alone.shadcnas a package and the 21 components insrc/components/uias vendored code. The shadcn/ui license text is inclient/licenses/vendored/shadcn-ui.txt, copied from upstream.shadcn@4.21.0and "shadcn/ui components (src/components/ui)", both with the MIT license text.